Added reference to paper for OAS integration work #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eytanadler
requested review from
a team,
bbrelje,
kanekosh,
bernardopacini and
hajdik
and removed request for
a team,
bbrelje and
kanekosh
Pull Request Test Coverage Report for Build 1740968238
💛 - Coveralls |
bernardopacini
previously approved these changes
Jan 24, 2022
There was a problem hiding this comment.
This looks good to me, although we also talked about this offline and I mentioned the approach of including this in the README instead.
Is this functionality that is not a part of OpenConcept / OAS and unique to this script, or is it a general OpenConcept functionality? If it is the latter, I would recommend including it in the README so that it is clearly visible when someone visits the repo and wants to utilize this work.
eytanadler
changed the title
bernardopacini
previously approved these changes
Jan 24, 2022
|
Ah ok I'll add it back then. Before this is merged, I'm also going to see if I can figure out some of the warnings in the tests. |
bernardopacini
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added a short note on the new OAS work with a bibtex citation to the paper and updated other outdated information on the readme.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
xin the boxes that apply.