Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotag #17

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Autotag #17

merged 5 commits into from
Jul 21, 2020

Conversation

bbrelje
Copy link
Collaborator

@bbrelje bbrelje commented Jul 21, 2020

Purpose

Fix a bunch of deprecations and introduce modified/improved integrator component

Type of change

What types of change is it?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Breaking change (python2 / openmdao2 no longer supported)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@bbrelje bbrelje requested a review from a team as a code owner July 21, 2020 14:59
@coveralls
Copy link

coveralls commented Jul 21, 2020

Pull Request Test Coverage Report for Build 153

  • 189 of 216 (87.5%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.7%) to 82.576%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openconcept/utilities/math/integrals.py 165 192 85.94%
Files with Coverage Reduction New Missed Lines %
openconcept/utilities/math/combine_split_comp.py 4 87.6%
Totals Coverage Status
Change from base Build 151: 2.7%
Covered Lines: 3398
Relevant Lines: 4115

💛 - Coveralls

@bbrelje bbrelje requested review from eytanadler and removed request for kanekosh and bernardopacini July 21, 2020 15:08
@eytanadler eytanadler merged commit d48e0ad into mdolab:master Jul 21, 2020
bbrelje added a commit that referenced this pull request Jul 21, 2020
* Openmdao 2.8 to 2.9 breaking change - fixes integration test

* Pin pytest-cov version to fix Travis build issue

* yet another attempt to get Travis functioning

* get sphinx plugin direct from openmdao instead of porting it

* Pin Sphinx to maintain py2 backward compatibility on Appveyor

* pin sphinxcontrib-websupport to avoid py2 compat issues on appveyor

* Basic doc updates (#13)

* Update docs, add thermal and hybrid integration test (#14)

* Update docs, add thermal and hybrid integration test

* clean up hybrid twin test, deprecate old spec energy interface

* More integration tests (#15)

* Update docs, add thermal and hybrid integration test

* clean up hybrid twin test, deprecate old spec energy interface

* All example aircraft included in integration testing

* Add CFM56 surrogate and B737-800 test case (#16)

* Add B737 model

* Cache surrogate models

* Bring cached krige surrogate into openconcept until it's in OpenMDAO

* add reg test for 737-800

* matplotlib dependency moved to pass tests

* py2 build failing - needs init.py

* Apparently coveralls is broken

* Py2 slightly different answer on reg tests

* Autotag (#17)

* eliminate the distinction between simpson intervals and num nodes

* Fix om 3.0 breaking change due to coding error

* Updated integrator class to create vars at configure time

* Fix deprecation warnings in tests

* Remove python 2 from test matrix now that we have hard openmdao 3 dependency

* Ben fixed everything and updated unit tests for new integration syntax

Co-authored-by: Ben Brelje <[email protected]>
Co-authored-by: Ben Brelje <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants