chore(macros/HTTPSidebar): remove Cookie Security link #9654
Conversation
jhongyu
force-pushed
the
cookie-security-link
branch
from
b712b51
to
2908748
Compare
jhongyu
force-pushed
the
cookie-security-link
branch
from
2908748
to
21a1de4
Compare
kumascript/macros/HTTPSidebar.ejs
Outdated
| @@ -321,7 +321,7 @@ var text = mdn.localStringMap({ | |||
| <ol> | |||
| <li><a href="/<%=locale%>/docs/Web/HTTP/CSP"><%=text['CSP']%></a></li> | |||
| <li><a href="/<%=locale%>/docs/Web/HTTP/Headers/Strict-Transport-Security">HTTP Strict Transport Security (HSTS)</a></li> | |||
| <li><a href="/<%=locale%>/docs/Web/HTTP/Cookies#Secure_and_HttpOnly_cookies">Cookie security</a></li> | |||
| <li><a href="/<%=locale%>/docs/Web/HTTP/Cookies#security">Cookie security</a></li> | |||
There was a problem hiding this comment.
The URI fragment is "locale-aware", for example, this should be "#安全" for zh-CN, "#安全性" for zh-TW, "#セキュリティ" for ja. Simply setting this as "#security" may not be a good idea.
There was a problem hiding this comment.
I've updated the links to adapt for different languages
caugner
changed the title
|
@jhongyu Sorry for taking so long to get back to you. Looking at that Security section on the Cookies page and seeing how small it is, I actually don't think it makes sense to have a dedicated link from the sidebar, so I would suggest to remove that link from the HTTPSidebar instead. What do you think? |
Sounds OK for me, I'll remove the link |
jhongyu
changed the title
Summary
Fixes #8946
Problem
The link of "Cookie security" in the HTTP security sidebar is
https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#Secure_and_HttpOnly_cookies, while this link doesn't exist in the "Cookies" pageSolution
Update the link of "Cookie security" in the HTTP security sidebar to
https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#securityScreenshots
Before
before.mp4
After
after.mp4