Deprecate Service Worker sidebar #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
approved these changes
Nov 24, 2022
|
@SphinxKnight , I'm not sure if I have to do anything (like ask :) for translators to work on removing a macro once it has been deprecated in Yari, or if this is automatically tracked somehow. |
|
@wbamberg thanks for the notification, I'll add an issue over on translated-content and will mention it on https://github.com/orgs/mdn/discussions/263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Service Worker API has its own dedicated sidebar, implemented using the ServiceWorkerSidebar.ejs macro.
There's no special reason it needs to do this, and in mdn/content#22469 I replaced it in en-US with the standard
{{DefaultAPISidebar}}macro.If we can do the same for translated content we can delete this sidebar.