-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(plus): add FAQ + and move {feature => features}/* #5707
Conversation
466489e
to
f86c6c5
Compare
This means we reuse the feature sidebarHeader for the FAQ as well.
f86c6c5
to
602416a
Compare
@Guyzeroth @schalkneethling To review, you will need to either restart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things to consider.
Co-authored-by: Schalk Neethling <[email protected]>
Looks really great. One small comment. |
Good point, @schalkneethling. I reused the style from the "Learn more" pages, but feel free to improve the style there. |
Summary
Fixes https://github.com/mdn/yari-private/issues/945.
Fixes https://github.com/mdn/foxfooding-mdn-plus/issues/58.
Problem
Folks will have questions about MDN Plus, but we don't have a FAQ page yet.
Solution
/en-US/plus/faq
plus/feature/*
toplus/features/*
to be consistent with thecopy/plus
structurecopy/plus
recursivelyNaN
by a properPageNotFound
error message.Link to it from the MDN Plus page(not for now)Screenshots
For non-Plus users:
For Plus users:
Feature pages (slug now have plural
features
):FAQ pages:
How did you test this change?