Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plus): add FAQ + and move {feature => features}/* #5707

Merged
merged 12 commits into from
Mar 23, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 21, 2022

Summary

Fixes https://github.com/mdn/yari-private/issues/945.
Fixes https://github.com/mdn/foxfooding-mdn-plus/issues/58.

Problem

Folks will have questions about MDN Plus, but we don't have a FAQ page yet.

Solution

  • Add a MDN Plus FAQ page at /en-US/plus/faq
  • Link to it from the MDN Plus menu (and make that item visible to everyone)
  • Rename plus/feature/* to plus/features/* to be consistent with the copy/plus structure
  • Build copy/plus recursively
  • Replace NaN by a proper PageNotFound error message.
  • Link to it from the MDN Plus page (not for now)

Screenshots

For non-Plus users:

image

For Plus users:
image

Feature pages (slug now have plural features):
image

FAQ pages:
image


How did you test this change?

  1. Open http://localhost:3000/en-US/plus/ and hover over the MDN Plus menu.
  2. Open http://localhost:3000/en-us/plus/faq
  3. Open http://localhost:3000/en-us/plus/features/notifications/

@caugner caugner force-pushed the plus-menu-add-faq-link branch from 466489e to f86c6c5 Compare March 21, 2022 22:22
@caugner caugner force-pushed the plus-menu-add-faq-link branch from f86c6c5 to 602416a Compare March 21, 2022 23:27
@caugner caugner changed the title chore(plus): add FAQ chore(plus): add FAQ + and move {feature => features}/* Mar 21, 2022
@caugner caugner marked this pull request as ready for review March 21, 2022 23:36
@caugner
Copy link
Contributor Author

caugner commented Mar 22, 2022

@Guyzeroth @schalkneethling To review, you will need to either restart yarn dev or run yarn tool spas once after checking out this branch.

Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to consider.

client/src/homepage/static-page/index.tsx Outdated Show resolved Hide resolved
build/spas.js Show resolved Hide resolved
client/src/homepage/static-page/index.tsx Outdated Show resolved Hide resolved
client/src/ui/molecules/plus-menu/index.tsx Outdated Show resolved Hide resolved
@Guyzeroth
Copy link
Contributor

Looks really great. One small comment.

@caugner caugner merged commit b739a61 into mdn:main Mar 23, 2022
@caugner caugner deleted the plus-menu-add-faq-link branch March 23, 2022 11:07
@schalkneethling
Copy link

Not something to solve now but just a general comment. The space between the page heading and the first FAQ seems very large. It feels like they are completely disconnected from each other. It also seems strange that the heading of the questions are so much larger that the page heading.

Screenshot 2022-03-23 at 13 04 49

@caugner
Copy link
Contributor Author

caugner commented Mar 23, 2022

The space between the page heading and the first FAQ seems very large. It feels like they are completely disconnected from each other.

Good point, @schalkneethling. I reused the style from the "Learn more" pages, but feel free to improve the style there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants