-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally delete from S3 what was NOT uploaded #3117
Merged
escattone
merged 7 commits into
mdn:main
from
peterbe:2224-optionally-delete-from-s3-what-was-not-uploaded
Mar 11, 2021
Merged
optionally delete from S3 what was NOT uploaded #3117
escattone
merged 7 commits into
mdn:main
from
peterbe:2224-optionally-delete-from-s3-what-was-not-uploaded
Mar 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
suggested changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbe Overall, nicely done, but I do have some comment nits, some suggested changes, and one bug fix.
peterbe
commented
Mar 11, 2021
peterbe
commented
Mar 11, 2021
This reverts commit 4bfd17c.
escattone
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @peterbe!
peterbe
deleted the
2224-optionally-delete-from-s3-what-was-not-uploaded
branch
March 11, 2021 20:51
This was referenced Mar 12, 2021
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
* optionally delete from S3 what was NOT uploaded Part of mdn#2224 * Apply suggestions from code review Co-authored-by: Ryan Johnson <[email protected]> * more feedbacked * rename the option properly * python lint * Revert "python lint" This reverts commit 4bfd17c. Co-authored-by: Ryan Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2224
The reason this PR does not claim to resolve #2224 is partly because 1) this new feature is not enabled yet in
prod-build.yml
, and 2) let's close the issue once we know it has fully worked in production.I'm not fond of the name
--delete-unrecognized
. But writer's block is real so I plowed through with it.--delete-old
is equally bad (or worse) because time isn't important (exception for static assets).What about
--delete-leftovers
? Or--delete-remaining
? Or--delete-not-uploaded
?I've been testing this locally with my personal S3 bucket which is only the en-US stuff. I have been uploading to that for testing the Deployer dating back to mid-2020. So my S3 bucket was full of all sorts of junk:
And if I run it a second time, immediately after I get:
Here, note the lines: