fix(ssr): fix --no-docs (rename to --skip-docs) #11973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And ssr spas in `yarn start`. This should be changed to be ad hoc ssred in the future.
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
reviewed
Oct 17, 2024
Comment on lines
+15
to
17
| .option("-s, --skip-docs", "Do not build docs (only spas, blog...)", { | ||
| default: false, | ||
| }) |
There was a problem hiding this comment.
@fiji-flo The solution would have been:
.option("--docs", "Build docs", {
default: true,
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix --no-docs (rename to --skip-docs)
And ssr spas in
yarn start.This should be changed to be ad hoc ssred in the future.
Problem
--no-docs had no effect and still rendered everything.
Solution
It seems like caporal magically (probably documented somewhere) strips the
nofrom--no-docsso the option is calleddocsinstead of the expectednoDocs. Therefore, this was broken. Now we use--skip-docsand it works as expected.How did you test this change?
Locally
yarn startand visit a http://localhost:5042/en-US/foo