Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only force URLs from know domains from http:// to https:// #3654

Closed
peterbe opened this issue Apr 29, 2021 · 0 comments · Fixed by #3657
Closed

Only force URLs from know domains from http:// to https:// #3654

peterbe opened this issue Apr 29, 2021 · 0 comments · Fixed by #3657
Assignees

Comments

@peterbe
Copy link
Contributor

peterbe commented Apr 29, 2021

Today, we're turn all external http:// URLs to https:// URLs. That doesn't make sense because some http:// URLs stop working if you do that. (See examples mentioned in the discussion referenced).
But there's still a LOT of http:// URLs that we know with certainty can be automatically converted to https:// for example http://codepen.io/xxx.

Let's only touch those that are safe. We'll do this by checking in a .json file which we maintain offline/manually.

Originally posted by @peterbe in https://github.com/mdn/yari/discussions/3651

@peterbe peterbe self-assigned this Apr 29, 2021
peterbe added a commit to peterbe/yari that referenced this issue Apr 29, 2021
peterbe added a commit that referenced this issue May 3, 2021
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant