Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix our auto-merge workflow #3217

Closed
peterbe opened this issue Mar 12, 2021 · 3 comments
Closed

Fix our auto-merge workflow #3217

peterbe opened this issue Mar 12, 2021 · 3 comments
Assignees
@peterbe

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 12, 2021

tl;dr; Dependabot PRs are now run in a way that it has no access to any write-access secrets. But auto-merge can be used if we switch to pull_request_target.

See ahmadnassri/action-dependabot-auto-merge#60
@peterbe peterbe self-assigned this Mar 12, 2021
peterbe added a commit to peterbe/yari that referenced this issue Mar 12, 2021
@peterbe
Fix our auto-merge workflow
8f55110 
Part of mdn#3217
@peterbe peterbe mentioned this issue Mar 12, 2021
Merged
escattone pushed a commit that referenced this issue Mar 12, 2021
@peterbe
Fix our auto-merge workflow (#3218)
660b2d1 
Part of #3217
@peterbe
Copy link
Contributor Author

peterbe commented Mar 12, 2021

It works!
#3212
and #3214
were merged thanks to #3218

@peterbe
Copy link
Contributor Author

peterbe commented Mar 12, 2021

Once mdn/content#3071 has proven to fix problems for content too, we can close this.

@peterbe
Copy link
Contributor Author

peterbe commented Mar 12, 2021

Don't be fooled to think it was me, the real Peter, who posted this: mdn/content#3073 (review)
It's the auto-merge workflow working again in mdn/content. Yay!

@peterbe peterbe closed this as completed Mar 12, 2021
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
@peterbe
Fix our auto-merge workflow (mdn#3218)
55cd124 
Part of mdn#3217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbe