Address some feedback, mostly rename things

mdn · Apr 16, 2021 · a30d53a · a30d53a
1 parent 7c38a6e
commit a30d53a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/build/document-extractor.js b/build/document-extractor.js
@@ -123,14 +123,13 @@ function extractSections($) {
  *        query: "foo.bar.thing",
  *        id: "specifications",
  *        title: "Specifications",
- *        spec_urls: {....}
+ *        specURLs: {....}
  *   }]
  */
 function addSections($) {
   const flaws = [];
 
-  const countPotentialSpecialDivs =
-    $.find("div.bc-data").length + $.find("div.bc-specs").length;
+  const countPotentialSpecialDivs = $.find("div.bc-data, div.bc-specs").length;
   if (countPotentialSpecialDivs) {
     /** If there's exactly 1 special table the only section to add is something
      * like this:
@@ -376,7 +375,7 @@ function _addSingleSpecialSection($) {
       },
     ];
   } else if (specialSectionType === "specifications") {
-    let spec_urls = [];
+    let specURLs = [];
 
     for (const [key, compat] of Object.entries(data)) {
       let block;
@@ -387,9 +386,9 @@ function _addSingleSpecialSection($) {
       }
       if (block && block.spec_url) {
         if (Array.isArray(block.spec_url)) {
-          spec_urls = block.spec_url;
+          specURLs = block.spec_url;
         } else {
-          spec_urls.push(block.spec_url);
+          specURLs.push(block.spec_url);
         }
       }
     }
@@ -401,8 +400,7 @@ function _addSingleSpecialSection($) {
           title,
           id,
           isH3,
-          spec_urls,
-          query,
+          specURLs,
         },
       },
     ];

diff --git a/client/src/document/spec-table.tsx b/client/src/document/spec-table.tsx
@@ -4,14 +4,12 @@ export function SpecificationTable({
   id,
   title,
   isH3,
-  spec_urls,
-  query,
+  specURLs,
 }: {
   id: string;
   title: string;
   isH3: boolean;
-  spec_urls: [];
-  query: string;
+  specURLs: string[];
 }) {
   return (
     <>
@@ -24,7 +22,7 @@ export function SpecificationTable({
           </tr>
         </thead>
         <tr>
-          <td>{spec_urls}</td>
+          <td>{specURLs}</td>
         </tr>
       </table>
     </>

diff --git a/kumascript/macros/specs.ejs → kumascript/macros/SpecificationTable.ejs b/kumascript/macros/specs.ejs → kumascript/macros/SpecificationTable.ejs
@@ -14,6 +14,9 @@ Example calls
 */
 
 var query = $0 || env['browser-compat'];
+if (!query) {
+  throw new Error("No first query argument or 'browser-compat' front-matter value passed");
+}
 var output = `<div class="bc-specs" data-bcd-query="${query}"></div>`;
 %>