chore(webpack): directly import fork-ts-checker-webpack-plugin

mdn · May 14, 2024 · 98e6b1a · 98e6b1a
1 parent 7da3f25
commit 98e6b1a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 19 deletions.
diff --git a/client/config/webpack.config.js b/client/config/webpack.config.js
@@ -16,11 +16,7 @@ import paths from "./paths.js";
 import getClientEnvironment from "./env.js";
 import createEnvironmentHash from "./webpack/persistentCache/createEnvironmentHash.js";
 
-const { default: ForkTsCheckerWebpackPlugin } = await import(
-  process.env.TSC_COMPILE_ON_ERROR === "true"
-    ? "react-dev-utils/ForkTsCheckerWarningWebpackPlugin.js"
-    : "react-dev-utils/ForkTsCheckerWebpackPlugin.js"
-);
+import ForkTsCheckerWebpackPlugin from "fork-ts-checker-webpack-plugin";
 
 // Source maps are resource heavy and can cause out of memory issue for large source files.
 const shouldUseSourceMap = process.env.GENERATE_SOURCEMAP !== "false";

diff --git a/client/scripts/build.js b/client/scripts/build.js
@@ -100,19 +100,9 @@ checkBrowsers(paths.appPath, isInteractive)
       );
     },
     (err) => {
-      const tscCompileOnError = process.env.TSC_COMPILE_ON_ERROR === "true";
-      if (tscCompileOnError) {
-        console.log(
-          chalk.yellow(
-            "Compiled with the following type errors (you may want to check these before deploying your app):\n"
-          )
-        );
-        printBuildError(err);
-      } else {
-        console.log(chalk.red("Failed to compile.\n"));
-        printBuildError(err);
-        process.exit(1);
-      }
+      console.log(chalk.red("Failed to compile.\n"));
+      printBuildError(err);
+      process.exit(1);
     }
   )
   .then(async () => {

diff --git a/package.json b/package.json
@@ -198,6 +198,7 @@
     "extend": "^3.0.2",
     "file-loader": "^6.2.0",
     "foreman": "^3.0.1",
+    "fork-ts-checker-webpack-plugin": "^9.0.2",
     "history": "^5.2.0",
     "html-validate": "^8.18.2",
     "html-webpack-plugin": "^5.6.0",

diff --git a/yarn.lock b/yarn.lock
@@ -7235,7 +7235,7 @@ foreman@^3.0.1:
     mustache "^2.2.1"
     shell-quote "^1.6.1"
 
-fork-ts-checker-webpack-plugin@>=6.5.0, fork-ts-checker-webpack-plugin@^6.5.0:
+fork-ts-checker-webpack-plugin@>=6.5.0, fork-ts-checker-webpack-plugin@^6.5.0, fork-ts-checker-webpack-plugin@^9.0.2:
   version "9.0.2"
   resolved "https://registry.yarnpkg.com/fork-ts-checker-webpack-plugin/-/fork-ts-checker-webpack-plugin-9.0.2.tgz#c12c590957837eb02b02916902dcf3e675fd2b1e"
   integrity sha512-Uochze2R8peoN1XqlSi/rGUkDQpRogtLFocP9+PGu68zk1BDAKXfdeCdyVZpgTk8V8WFVQXdEz426VKjXLO1Gg==