Skip to content

Commit

Permalink
chore(deps)!: bump NodeJS from v18 to v20 (#12052)
Browse files Browse the repository at this point in the history
* chore(deps)!: bump NodeJS from Node v18 to v20

* chore(build): update deprecation warning
  • Loading branch information
fiji-flo authored Oct 30, 2024
1 parent ccc76da commit 263f4a2
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/prod-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ jobs:
for region in europe-west1 us-west1 asia-east1; do
gcloud beta functions deploy mdn-prod-prod-$region \
--gen2 \
--runtime=nodejs18 \
--runtime=nodejs20 \
--region=$region \
--source=cloud-function \
--trigger-http \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stage-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ jobs:
for region in europe-west1 us-west1 asia-east1; do
gcloud beta functions deploy mdn-nonprod-stage-$region \
--gen2 \
--runtime=nodejs18 \
--runtime=nodejs20 \
--region=$region \
--source=cloud-function \
--trigger-http \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ jobs:
for region in europe-west3; do
gcloud beta functions deploy mdn-nonprod-test-$region \
--gen2 \
--runtime=nodejs18 \
--runtime=nodejs20 \
--region=$region \
--source=cloud-function \
--trigger-http \
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
2 changes: 1 addition & 1 deletion build/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ program
try {
if (!options.nohtml) {
console.warn(
"WARNING: Rendering index.html files as part of the build command is now DEPRECATED, and will no longer be supported in Yari v3. To resolve this warning, add the `-n` (`--nohtml`) option. For details, see: https://github.com/mdn/yari/pull/10953"
"WARNING: Rendering index.html files as part of the build command is now DEPRECATED, and will no longer be supported in Yari in the near future. To resolve this warning, add the `-n` (`--nohtml`) option. For details, see: https://github.com/mdn/yari/pull/10953"
);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,6 @@
"webpack-node-externals": "^3.0.0"
},
"engines": {
"node": ">=18.18.0"
"node": ">=20"
}
}

0 comments on commit 263f4a2

Please sign in to comment.