-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync Markdownlint jobs from mdn/content #81
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"problemMatcher": [ | ||
{ | ||
"owner": "markdownlint", | ||
"severity": "warning", | ||
"pattern": [ | ||
{ | ||
"regexp": "^([^:]*):(\\d+):?(\\d+)?\\s([\\w-\\/]*)\\s(.*)$", | ||
"file": 1, | ||
"line": 2, | ||
"column": 3, | ||
"code": 4, | ||
"message": 5 | ||
} | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
name: Markdownlint (PR files) | ||
|
||
# Used to run linting only on the files changed in a PR. | ||
# This is useful in conjunction with the other global Markdownlint job, | ||
# which will test larger configuration changes across a repository. | ||
# A sample filter to only run the job when a PR touches a Markdown file | ||
# on: | ||
# pull_request: | ||
# branches: | ||
# - main | ||
# paths: | ||
# - "**/*.md" | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
target-repo: | ||
description: The repo to run this action on. This is to prevent actions from running on forks unless intended. | ||
required: true | ||
type: string | ||
node-version: | ||
description: The node version to setup and use. | ||
default: 16 | ||
required: false | ||
type: number | ||
cache: | ||
description: Which package manager cache to use | ||
default: "yarn" | ||
required: false | ||
type: string | ||
install-command: | ||
description: The command to install the package dependencies. | ||
default: "yarn --frozen-lockfile" | ||
required: false | ||
type: string | ||
changed-filter: | ||
description: File filter glob to limit which changed files to lint | ||
default: "**/*.md" | ||
required: false | ||
type: string | ||
lint-command: | ||
description: Which commmand or script used to invoke Markdown linting | ||
default: "yarn markdownlint-cli2 ${files_to_lint}" | ||
required: false | ||
type: string | ||
|
||
jobs: | ||
markdown-lint: | ||
if: github.repository == ${{ inputs.target-repo }} | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
|
||
- name: Get changed files | ||
id: changed-files | ||
uses: tj-actions/[email protected] | ||
with: | ||
files: ${{ inputs.changed-filter }} | ||
|
||
- name: Setup Node.js environment | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ inputs.node-version }} | ||
cache: ${{ inputs.cache }} | ||
|
||
- name: Install packages | ||
run: ${{ inputs.install-command }} | ||
|
||
- name: Lint Markdown files | ||
run: | | ||
echo "::add-matcher::.github/workflows/markdownlint-problem-matcher.json" | ||
files_to_lint="${{ steps.changed-files.outputs.all_changed_files }}" | ||
${{ inputs.lint-command }} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to change like it did upstream, but I haven't checked what they moved to