Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update eslint and CI #532

Merged
merged 4 commits into from
Oct 31, 2023
Merged

chore: update eslint and CI #532

merged 4 commits into from
Oct 31, 2023

Conversation

uiolee
Copy link
Contributor

@uiolee uiolee commented Jul 7, 2023 •
edited
Loading

Description

Update eslint and CI

  • bump update eslint version
  • update eslint config
  • deprecate babel-eslint with @babel/eslint-parser
  • use github-actions CI, drop travisCI

Related issues and pull requests

fix #525

Rob--W
Rob--W requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change .eslintrc.js back to .eslintrc.json.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@uiolee uiolee marked this pull request as draft July 11, 2023 02:10
@uiolee uiolee marked this pull request as ready for review July 11, 2023 02:23
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 10, 2023
@rebloor
Copy link
Collaborator

rebloor commented Aug 11, 2023

@Rob--W ready to approve/merge?

@rebloor rebloor requested a review from Rob--W August 11, 2023 18:08
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Aug 12, 2023
@uiolee uiolee changed the title Update eslint and CI chore: update eslint and CI Aug 30, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Sep 30, 2023
@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Oct 14, 2023
@Rob--W Rob--W merged commit cad6550 into mdn:main Oct 31, 2023
@github-actions GitHub Actions
Copy link

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@Rob--W Rob--W mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update eslint, fix linting errors and integrate in CI
3 participants
@uiolee @rebloor @Rob--W