Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESLint & Travis CI #244

Merged
merged 10 commits into from
Jul 14, 2017
Merged

Add ESLint & Travis CI #244

merged 10 commits into from
Jul 14, 2017

Conversation

yfdyh000
Copy link
Contributor

@yfdyh000 yfdyh000 commented Jul 8, 2017

@wbamberg
Copy link

wbamberg commented Jul 9, 2017

This looks great to me, but it's also a significant change to the policy for this code. I'd love it if @rpl and @andymckay could take a look at this and comment on whether this policy, and this particular ESLint configuration, looks good to them.

Copy link

@andymckay andymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on eslint, but this looks like a good start to me and its something we can tweak later if we want to. Thanks @yfdyh000 for doing this, I think it will make the repo better.

@andymckay andymckay merged commit 6dd128a into mdn:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants