Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] update the translation of <colgroup> element #20331

Merged
merged 5 commits into from
May 16, 2024
Merged

Conversation

jasonren0403
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

@jasonren0403 jasonren0403 requested a review from a team as a code owner May 13, 2024 04:07
@jasonren0403 jasonren0403 requested review from JasonLamv-t and removed request for a team May 13, 2024 04:07
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label May 13, 2024
jasonren0403 and others added 2 commits May 13, 2024 16:25
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented May 13, 2024

Preview URLs

Flaws (15)

URL: /zh-CN/docs/Web/HTML/Element/colgroup
Title: <colgroup>:表格列组元素
Flaw count: 15

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/dirname does not exist but fell back to /en-US/docs/Web/HTML/Attributes/dirname
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • /zh-CN/docs/Web/HTML/Attributes/maxlength does not exist but fell back to /en-US/docs/Web/HTML/Attributes/maxlength
    • and 9 more flaws omitted
  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)
External URLs (1)

URL: /zh-CN/docs/Web/HTML/Element/colgroup
Title: <colgroup>:表格列组元素

(comment last updated: 2024-05-15 01:48:55)

Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx! @jasonren0403

Comment on lines 83 to 123
```html
<table>
<caption>
个人每周活动
</caption>
<colgroup>
<col />
<col span="5" class="weekdays" />
<col span="2" class="weekend" />
</colgroup>
<tr>
<th>时段</th>
<th>周一</th>
<th>周二</th>
<th>周三</th>
<th>周四</th>
<th>周五</th>
<th>周六</th>
<th>周日</th>
</tr>
<tr>
<th>上午</th>
<td>打扫房间</td>
<td>足球训练</td>
<td>舞蹈课</td>
<td>历史课</td>
<td>买饮料</td>
<td>自习</td>
<td>自由时间</td>
</tr>
<tr>
<th>下午</th>
<td>瑜伽</td>
<td>棋类俱乐部</td>
<td>见朋友</td>
<td>体操</td>
<td>生日派对</td>
<td>钓鱼之旅</td>
<td>自由时间</td>
</tr>
</table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change you made, that is, adding the th in the tr elemment, is better. Going to update the upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I've copied them from <col> examples...

I would update them to match the original document.

files/zh-cn/web/html/element/colgroup/index.md Outdated Show resolved Hide resolved
Copy link
Member

@JasonLamv-t JasonLamv-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, LGTM now. Thx @jasonren0403.

@JasonLamv-t JasonLamv-t merged commit 450965c into main May 16, 2024
8 checks passed
@JasonLamv-t JasonLamv-t deleted the colgroup-zhcn branch May 16, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants