-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh-cn] update the translation of <colgroup>
element
#20331
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Preview URLs Flaws (15)URL:
External URLs (1)URL:
(comment last updated: 2024-05-15 01:48:55) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx! @jasonren0403
```html | ||
<table> | ||
<caption> | ||
个人每周活动 | ||
</caption> | ||
<colgroup> | ||
<col /> | ||
<col span="5" class="weekdays" /> | ||
<col span="2" class="weekend" /> | ||
</colgroup> | ||
<tr> | ||
<th>时段</th> | ||
<th>周一</th> | ||
<th>周二</th> | ||
<th>周三</th> | ||
<th>周四</th> | ||
<th>周五</th> | ||
<th>周六</th> | ||
<th>周日</th> | ||
</tr> | ||
<tr> | ||
<th>上午</th> | ||
<td>打扫房间</td> | ||
<td>足球训练</td> | ||
<td>舞蹈课</td> | ||
<td>历史课</td> | ||
<td>买饮料</td> | ||
<td>自习</td> | ||
<td>自由时间</td> | ||
</tr> | ||
<tr> | ||
<th>下午</th> | ||
<td>瑜伽</td> | ||
<td>棋类俱乐部</td> | ||
<td>见朋友</td> | ||
<td>体操</td> | ||
<td>生日派对</td> | ||
<td>钓鱼之旅</td> | ||
<td>自由时间</td> | ||
</tr> | ||
</table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change you made, that is, adding the th
in the tr
elemment, is better. Going to update the upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, I've copied them from <col>
examples...
I would update them to match the original document.
Co-authored-by: Jason Lam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, LGTM now. Thx @jasonren0403.
Description
Motivation
Additional details
Related issues and pull requests