Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Bump actions/labeler from 4 to 5 #18402

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Mar 5, 2024

Description

Bump actions/labeler from 4 to 5.

The new input: sync-label is added to automatically remove unmatched labels (which is configured in label matching entries)

Motivation

All the actions which is running on Node 16 will be migrated to Node 20. And the actions/labeler@v4 is running on Node 16 which may not be supported in the future.

Related issues and pull requests

#17278
testing: #18403, see debug log.

@github-actions github-actions bot added the system Infrastructure and configuration for the project label Mar 5, 2024
@yin1999 yin1999 marked this pull request as ready for review March 5, 2024 06:24
@yin1999 yin1999 requested a review from a team as a code owner March 5, 2024 06:24
@yin1999
Copy link
Member Author

yin1999 commented Mar 5, 2024

/cc @bsmth, @queengooborg

@bsmth
Copy link
Member

bsmth commented Mar 7, 2024

automatically remove unmatched labels

Will this remove a label that I manually added? Or the automated pr label, will that be removed?

@yin1999
Copy link
Member Author

yin1999 commented Mar 7, 2024

automatically remove unmatched labels

Will this remove a label that I manually added? Or the automated pr label, will that be removed?

It will not be removed:

According to the sync logic. Only the labels configured in the .github/labeler.yml files would be managed by the labeler (that is the label such as automated pr will not be removed by labeler as it is not configured in the config file)

I've tested this in #18403 by adding the community label and re-run the labeler, and the community label is still there :)

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's give it a try! Thank you!

@yin1999 yin1999 merged commit b3e774b into mdn:main Mar 8, 2024
7 of 8 checks passed
@yin1999 yin1999 deleted the bump-labeler branch March 8, 2024 00:42
@yin1999
Copy link
Member Author

yin1999 commented Mar 8, 2024

It works well:

We can now apply the corresponding changes to the mdn/content repository :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants