Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] Update response.url #14923

Merged
merged 4 commits into from
Sep 21, 2023
Merged

[zh-cn] Update response.url #14923

merged 4 commits into from
Sep 21, 2023

Conversation

jasonren0403
Copy link
Contributor

@jasonren0403 jasonren0403 commented Aug 5, 2023

Description

clear untranslated content

Motivation

Additional details

Related issues and pull requests

part of #14272

blocked by mdn/content#28412

@jasonren0403 jasonren0403 requested a review from a team as a code owner August 5, 2023 12:05
@jasonren0403 jasonren0403 requested review from yin1999 and removed request for a team August 5, 2023 12:05
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/API/Response/url
Title: Response:url 属性
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/URL/createObjectURL redirects to /zh-CN/docs/Web/API/URL/createObjectURL_static
External URLs (1)

URL: /zh-CN/docs/Web/API/Response/url
Title: Response:url 属性

(comment last updated: 2023-09-21 03:32:34)

Comment on lines 25 to 31
fetch(myRequest).then((response) => {
console.log(response.url); // 返回 https://developer.mozilla.org/en-US/docs/Web/API/Response/flowers.jpg
response.blob().then((myBlob) => {
const objectURL = URL.createObjectURL(myBlob);
myImage.src = objectURL;
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code example is not match with the source file. Could you also update the en-US document :)

files/zh-cn/web/api/response/url/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 added the needs content update Needs update to the content to support this change. label Aug 12, 2023
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Aug 14, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@yin1999
Copy link
Member

yin1999 commented Aug 14, 2023

I haven't notice that the file has been removed in #15095. Sorry about that

@jasonren0403
Copy link
Contributor Author

I haven't notice that the file has been removed in #15095. Sorry about that

Should I reopen this PR 🤔

@yin1999
Copy link
Member

yin1999 commented Aug 15, 2023

I haven't notice that the file has been removed in #15095. Sorry about that

Should I reopen this PR 🤔

Merge main branch and keep this file when resolving the conflict.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Aug 17, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jasonren0403

@yin1999 yin1999 removed the needs content update Needs update to the content to support this change. label Sep 21, 2023
@yin1999 yin1999 merged commit a55870e into main Sep 21, 2023
8 checks passed
@yin1999 yin1999 deleted the jasonren0403-response-url branch September 21, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants