-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fr: Removes duplicated frontmatter keys (web folder) #13664
Conversation
Preview URLs (298 pages)
Flaws (1864)Note! 19 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
pages is not iterable`
URL:
URL:
URL:
URL:
URL:
URL:
pages is not iterable`
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (318)URL:
URL:
URL:
URL:
URL:
URL: URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL: URL:
URL:
URL:
URL:
URL:
URL: URL: URL:
URL:
URL:
URL: URL: URL: URL:
URL: URL: URL:
URL:
URL:
URL:
URL:
URL: URL:
URL: URL: URL: URL:
URL:
URL:
URL: URL: URL: URL: URL:
URL:
URL: URL: URL:
URL:
URL: URL:
URL: URL: URL:
URL:
URL: URL:
URL: URL:
URL:
URL:
URL: URL:
URL: URL: URL:
URL:
URL: URL:
URL: URL: URL:
URL: URL: URL: URL:
URL: URL:
URL:
URL: URL: URL: URL: URL:
URL:
URL:
URL: URL:
URL:
URL:
URL:
URL: URL:
URL:
URL:
URL: URL: URL: URL: URL: URL: URL: URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL: URL:
URL: URL:
URL:
URL:
URL: URL: URL:
URL: URL:
URL: URL:
URL:
URL:
URL:
URL: URL: URL: URL: (comment last updated: 2023-07-20 15:23:37) |
This comment was marked as outdated.
This comment was marked as outdated.
This pull request has merge conflicts that must be resolved before it can be merged. |
Sorry for the delay here :/ Even though the changes are simple, there are a lot of files so it will take some time, but I hope to finish the review soon. |
@Lou8is sorry for being late to the party as well, just in case you were to work on similar "huge surface changes", I'd advocate to split the work in separate PRs for each subsection of /web. |
Yeah my bad on this one, I now understand that /web and /learn are very hyge in comparison to other folders. I'll keep that in mind in the future. Take all the time your need I'll try to keep it up to date with main if needed. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK pour moi. j'ai plutôt joué en local avec git diff --merge-base main HEAD
puis isolé les ajouts (grep -E "^\+" log_diff_pr13664.diff > add_diff.txt
) et suppressions (grep -E "^-" log_diff_pr13664.diff > sub_diff.txt
) pour voir :
- que rien n'avait été ajouté ✔️
- que sur les retraits, on avait bien que des tags et autres met
J'ai aussi vérifié sur le contenu les passages à la ligne avec >-
et vérifié que les l10n.sourceCommit
étaient inchangés.
Vu le volume, on attend @cw118 pour la suite :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tout est bon pour moi (je me suis permis de pousser un commit pour supprimer spec-urls
) :)
Merci à nouveau @Lou8is pour tout le travail ici et merci beaucoup @SphinxKnight pour la revue supplémentaire 🙏 🙏
Merci à tous les deux ! |
Description
Removes duplicated frontmatter keys (see #7412) from the files/fr/web sub-folder.
Only
title
,short_title
,slug
andl10n.*
are left, essentially removedtags
,original_slug
,browser-compat
,file-type
.Motivation
Help keeping the FR translation nice and up-to-date :)
Additional details
Related issues and pull requests
Relates to #7412
Relates to 6 other PR for the other subfolders (#13629, #13630, #13631, #13632, #13633, #13663)