Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {{ServiceWorkerSidebar}} macro from ja #10195

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove {{ServiceWorkerSidebar}} macro from ja #10195

merged 1 commit into from
Nov 30, 2022

Conversation

YujiSoftware
Copy link
Contributor

Description

Remove {{ServiceWorkerSidebar}} macro from ja

Related issues and pull requests

Part of #10170

@YujiSoftware YujiSoftware requested a review from a team as a code owner November 26, 2022 09:12
@YujiSoftware YujiSoftware requested review from dynamis and removed request for a team November 26, 2022 09:12
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Nov 26, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws (7)

URL: /ja/docs/Web/API/Service_Worker_API
Title: サービスワーカー API
Flaw count: 2

  • macros:
    • /ja/docs/Web/API/InstallEvent does not exist but fell back to /en-US/docs/Web/API/InstallEvent
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /ja/docs/Web/API/Service_Worker_API/Using_Service_Workers
Title: サービスワーカーの使用
Flaw count: 5

  • macros:
    • /ja/docs/Web/API/ServiceWorker/register does not exist
    • /ja/docs/Web/API/NavigationPreloadManager/enable does not exist but fell back to /en-US/docs/Web/API/NavigationPreloadManager/enable
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /ja/docs/Tools/about:debugging
    • Can't resolve /ja/docs/Tools/Settings

mfuji09
mfuji09 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。

@mfuji09 mfuji09 merged commit 23ad78b into mdn:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfuji09 mfuji09 mfuji09 approved these changes

@dynamis dynamis Awaiting requested review from dynamis dynamis is a code owner automatically assigned from mdn/yari-content-ja

Assignees
No one assigned
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YujiSoftware @mfuji09