Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gh-pages): build dir is now 'dist', add yarn caching and nvmrc #101

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Dec 21, 2023

Some changes breaking GitHub pages deploy after #97

failing builds:

Logs:

Run actions/upload-pages-artifact@v3
  with:
    path: build
    name: github-pages
    retention-days: 1
  env:
    GITHUB_PAGES: true
Run tar \
  tar \
    --dereference --hard-dereference \
    --directory "$INPUT_PATH" \
    -cvf "$RUNNER_TEMP/artifact.tar" \
    --exclude=.git \
    --exclude=.github \
    .
  shell: /usr/bin/sh -e {0}
  env:
    GITHUB_PAGES: true
    INPUT_PATH: build
tar: build: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Error: Process completed with exit code 2.

Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisdavidmills chrisdavidmills merged commit a2daa53 into mdn:main Dec 21, 2023
4 checks passed
@bsmth bsmth deleted the pages-build-dir branch December 21, 2023 13:14
@bsmth
Copy link
Member Author

bsmth commented Dec 21, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants