Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Specifications link for ShadowRoot.delegatesFocus should be removed #3917

Closed
1 of 2 tasks
unarist opened this issue Nov 23, 2020 · 2 comments
Closed
1 of 2 tasks

Specifications link for ShadowRoot.delegatesFocus should be removed #3917

unarist opened this issue Nov 23, 2020 · 2 comments
Labels
10 minute task This is a really quick task to fix, estimated 10 minutes or less. Content:WebAPI For content triage purposes: This is related to WebAPI content

Comments

@unarist
Copy link

unarist commented Nov 23, 2020

Request type

  • [] Please close this issue, I accidentally submitted it without adding any details
  • New documentation
  • Correction or update

Details

https://wiki.developer.mozilla.org/en-US/docs/Web/API/ShadowRoot/delegatesFocus

This article refers to https://dom.spec.whatwg.org/#shadowroot-delegates-focus but the spec only mentions about an internal field, not a public attribute on interfaces. So the link should be removed I think.
@chrisdavidmills chrisdavidmills added 10 minute task This is a really quick task to fix, estimated 10 minutes or less. 30 minute task This is a fairly quick issue to fix, estimated time 30 minutes. Content:WebAPI For content triage purposes: This is related to WebAPI content and removed 30 minute task This is a fairly quick issue to fix, estimated time 30 minutes. labels Nov 24, 2020
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Dec 9, 2020
@sideshowbarker
Mark ShadowRoot.p.delegatesFocus non-standard
afa4a20 
This change marks ShadowRoot.prototype.delegatesFocus standard_track:false
and deprecated:true. https://dom.spec.whatwg.org/#interface-shadowroot
doesn’t actually define any such exposed property — neither for
ShadowRoot nor for the interfaces it inherits from.

Blink/Chrome does expose such a property, but that’s not due to any
actual spec requirements.

Related: mdn/sprints#3917
@sideshowbarker sideshowbarker mentioned this issue Dec 9, 2020
Merged
@sideshowbarker
Copy link

sideshowbarker commented Dec 9, 2020 •
edited
Loading

cc @gregwhitworth, who added the spec link (to place in the spec where the internal field is defined)

For the record here, in Blink ShadowRoot objects do expose a delegatesFocus attribute — because the Blink IDL at https://chromium.googlesource.com/chromium/src/+/refs/heads/master/third_party/blink/renderer/core/dom/shadow_root.idl has it. But it’s not clear why — since no such property is defined in the IDL at https://dom.spec.whatwg.org/#interface-shadowroot for ShadowRoot, nor defined in the interface chain ShadowRoot inherits from (Node/DocumentFragment)

So I’ve raised mdn/browser-compat-data#7620 to mark this as non-standard in BCD.

ddbeck pushed a commit to mdn/browser-compat-data that referenced this issue Dec 10, 2020
@sideshowbarker
Mark ShadowRoot.p.delegatesFocus non-standard (#7620)
75a3ca7 
This change marks ShadowRoot.prototype.delegatesFocus standard_track:false
and deprecated:true. https://dom.spec.whatwg.org/#interface-shadowroot
doesn’t actually define any such exposed property — neither for
ShadowRoot nor for the interfaces it inherits from.

Blink/Chrome does expose such a property, but that’s not due to any
actual spec requirements.

Related:
mdn/sprints#3917
whatwg/dom#931
@chrisdavidmills
Copy link
Contributor

I think I've fixed the spec link too: mdn/content@196fb5d

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
10 minute task This is a really quick task to fix, estimated 10 minutes or less. Content:WebAPI For content triage purposes: This is related to WebAPI content
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisdavidmills @sideshowbarker @unarist