-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace spec table with {{specifications}} for api/d[a-n]* #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoli2003
changed the title
Replace spec table with {{specifications}} for api/d[a-n]* [DRAFT]
Replace spec table with {{specifications}} for api/d[a-n]*
Jun 12, 2021
sideshowbarker
approved these changes
Jun 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part #1146.
This converts API interfaces (including properties & methods) starting with 'da' to 'dn' to the {{Specifications}} macros.
A few notes:
DisplayMediaStreamConstraints
,DisplayMediaStreamConstraints.audio
, andDisplayMediaStreamConstraints
lose their spec table; it is a dictionary that is used only at one place, and BCD is broken anyway. This will be dealt when we will restructure dictionaries documentation all over the place (especially those used at one place).DecompressionStream
and its 2 children lose their spec table. This will be fixed by Add mdn_url and spec_url to CompressionStream and all its children browser-compat-data#10966.DataTransferItem.getAsFileSystemHandle()
is non-standard and has bcd but no spec. The previous table was bogus anyway. I've opened Improve message displayed by {{Specifications}} when not on a standard track and bcd present yari#4012 to have a better message displayed.DeviceLightEvent
is also non-standard, has bcd and no spec. The previous table was also bogus. The same Improve message displayed by {{Specifications}} when not on a standard track and bcd present yari#4012 issue will bring a better message here too.DeprecationReportBody
loses its table but has no bcd info. This will be fixed when we add its bcd_info in the future.All other pages look fine.