-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace spec table with {{specifications}} for api/c[r-z]* #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace spec table with {{specifications}} for api/c[r-t]*
teoli2003
changed the title
Replace spec table with {{specifications}} for api/c[r-t]* [DRADR]
Replace spec table with {{specifications}} for api/c[r-t]* [DRAFT]
Jun 11, 2021
teoli2003
changed the title
Replace spec table with {{specifications}} for api/c[r-t]* [DRAFT]
Replace spec table with {{specifications}} for api/c[r-z]* [DRAFT]
Jun 12, 2021
teoli2003
changed the title
Replace spec table with {{specifications}} for api/c[r-z]* [DRAFT]
Replace spec table with {{specifications}} for api/c[r-z]*
Jun 12, 2021
sideshowbarker
approved these changes
Jun 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part #1146.
This converts API interfaces (including properties & methods) starting with 'cr' to 'cz' to the {{Specifications}} macros.
A few notes:
CSSConditionRule.conditionText
is losing its spec table. I'm updating mdn/bcd (compat data was also missing) in Add BCD info for CSSConditionRule.conditionText browser-compat-data#10968; it will be automatically fixed after that PR lands.CSSNumericValue.sum
was bogus (looked like half .sub–half .sum). I've removed it from this PR and opened Delete CSSNumericValue.sum #5924 for its removal (not in the spec, not in chromium, and marked as draft).CSSStyleDeclaration.getPropertyCSSValue()
,CSSValueList
and 2 children,CSSValue
and 2 children,CSSPrimitiveValue
and 6 children.CrashReportBody
has no bcd and seems partially documented. It will be revisited anyway when bcd will be added. So I kept it.All other pages look fine.