Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use {{Specifications}} macro for svg/element/* #5856

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Use {{Specifications}} macro for svg/element/* #5856

merged 1 commit into from
Jun 10, 2021

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Jun 10, 2021 •
edited
Loading

This is part #1146.

This converts SVG elements to the {{Specifications}} macros. This is my first PR of this type, so a thorough review is needed.

There were no comments in the section, so it was pretty trivial to replace.

reviewer: @Elchi3

@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 79 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/SVG/Element/feMergeNode
Title: <feMergeNode>
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/DOM/SVGFEMergeNodeElement

URL: /en-US/docs/Web/SVG/Element/glyphRef
Title: <glyphRef>
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/DOM/SVGGlyphRefElement

External URLs

URL: /en-US/docs/Web/SVG/Element/image
Title: <image>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font-face
Title: <font-face>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/mask
Title: <mask>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/filter
Title: <filter>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feOffset
Title: <feOffset>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/polyline
Title: <polyline>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feDistantLight
Title: <feDistantLight>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feConvolveMatrix
Title: <feConvolveMatrix>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/script
Title: <script>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/ellipse
Title: <ellipse>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/missing-glyph
Title: <missing-glyph>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/glyph
Title: <glyph>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feComposite
Title: <feComposite>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feComponentTransfer
Title: <feComponentTransfer>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/animateTransform
Title: <animateTransform>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feDisplacementMap
Title: <feDisplacementMap>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/radialGradient
Title: <radialGradient>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/svg
Title: <svg>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feMorphology
Title: <feMorphology>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/altGlyph
Title: <altGlyph>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/desc
Title: <desc>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/foreignObject
Title: <foreignObject>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/defs
Title: <defs>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font
Title: <font>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feDiffuseLighting
Title: <feDiffuseLighting>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/hkern
Title: <hkern>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feMergeNode
Title: <feMergeNode>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feTurbulence
Title: <feTurbulence>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/line
Title: <line>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/path
Title: <path>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/set
Title: <set>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feBlend
Title: <feBlend>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feMerge
Title: <feMerge>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/polygon
Title: <polygon>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/linearGradient
Title: <linearGradient>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/style
Title: <style>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/discard
Title: <discard>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/rect
Title: <rect>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feSpotLight
Title: <feSpotLight>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feTile
Title: <feTile>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/textPath
Title: <textPath>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feFuncA
Title: <feFuncA>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feGaussianBlur
Title: <feGaussianBlur>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/circle
Title: <circle>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/g
Title: <g>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/cursor
Title: <cursor>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/marker
Title: <marker>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/text
Title: <text>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/glyphRef
Title: <glyphRef>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/animateColor
Title: <animateColor>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feFuncB
Title: <feFuncB>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/symbol
Title: <symbol>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font-face-name
Title: <font-face-name>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/pattern
Title: <pattern>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feFuncR
Title: <feFuncR>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/use
Title: <use>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/animateMotion
Title: <animateMotion>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/fePointLight
Title: <fePointLight>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feColorMatrix
Title: <feColorMatrix>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/switch
Title: <switch>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feFlood
Title: <feFlood>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/vkern
Title: <vkern>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/altGlyphItem
Title: <altGlyphItem>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font-face-uri
Title: <font-face-uri>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/clipPath
Title: <clipPath>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/tspan
Title: <tspan>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/title
Title: <title> — the SVG accessible name element
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/altGlyphDef
Title: <altGlyphDef>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feImage
Title: <feImage>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/metadata
Title: <metadata>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/view
Title: <view>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/mpath
Title: <mpath>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feDropShadow
Title: <feDropShadow>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feSpecularLighting
Title: <feSpecularLighting>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/a
Title: <a>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/tref
Title: <tref>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font-face-format
Title: <font-face-format>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/animate
Title: <animate>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/font-face-src
Title: <font-face-src>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/stop
Title: <stop>
on GitHub

No new external URLs

URL: /en-US/docs/Web/SVG/Element/feFuncG
Title: <feFuncG>
on GitHub

No new external URLs

@teoli2003 teoli2003 marked this pull request as ready for review June 10, 2021 15:50
@teoli2003 teoli2003 requested a review from a team June 10, 2021 15:50
Ryuno-Ki
Ryuno-Ki reviewed Jun 10, 2021
View reviewed changes
Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will make us loose some information, @Elchi3.
Especially the comments column (see https://pr5856.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Element/image for example).

However, I don't see, how this could be avoided using the new macro.
Perhaps worth to pull it out of the table and into paragraphs below?

@teoli2003
Copy link
Contributor Author

In this example, the information in the comment column is the difference between two versions of specification. They are useless for the web developer.

AFAIK, there shouldn't be useful info (for the webdev) in this column (it is different for the "historian" digging into the evolution of a feature)

@sideshowbarker sideshowbarker merged commit 91456ea into mdn:main Jun 10, 2021
@Elchi3
Copy link
Member

Elchi3 commented Jun 11, 2021

Our thoughts on removing these notes have been:

  • Specs can publish their own changelogs (and often do). This is more accurate and maintainable than us having notes in the tables.
  • Compat tables already talk about new sub features / new sub aspects of a feature when there is compat impact for web developers.

@Elchi3
Copy link
Member

Elchi3 commented Jun 11, 2021 •
edited
Loading

The spec titles here are often "SVG 1.1" when they should be "SVG 2", see https://pr5856.content.dev.mdn.mozit.cloud/en-US/docs/Web/SVG/Element/image#specifications. The link to SVG 2 is correct there but not the title.

I filed w3c/browser-specs#312 to see if the data source could be changed. If not, I need to tweak the code that generates our specification tables to fix this bug.

No follow-up required on mdn/content, though. Thanks for rolling this out to more pages!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ryuno-Ki Ryuno-Ki Ryuno-Ki left review comments

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teoli2003 @Elchi3 @sideshowbarker @Ryuno-Ki