Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ServiceWorkerState into ServiceWorker.state #5660

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

teoli2003
Copy link
Contributor

This fixes #5617.

ServiceWorkerState is an enum only used in ServiceWorker.state. From a developer perspective it is a JS String with a fixed state of values.

This, it is better to describe the values directly in ServiceWorker.state, and to completely hide ServiceWorkerState from the developer (like mixins, it is an implementation detail).

This PR does this.

@teoli2003 teoli2003 requested review from a team as code owners June 4, 2021 06:22
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team June 4, 2021 06:22
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Preview URLs

Flaws

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Service_Worker_API
Title: Service Worker API
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PeriodicSyncRegistration does not exist
    • /en-US/docs/Web/API/SyncRegistration does not exist

External URLs

URL: /en-US/docs/Web/API/Service_Worker_API
Title: Service Worker API
on GitHub


URL: /en-US/docs/Web/API/ServiceWorker/state
Title: ServiceWorker.state
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit b9df872 into mdn:main Jun 4, 2021
@teoli2003 teoli2003 deleted the merge-ServiceWorkerState branch June 4, 2021 06:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ServiceWorkerState by merging it into ServiceWorker.state
2 participants