Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dl rather than a table for attr values #5524

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented Jun 1, 2021

This removes the inline styles from https://developer.mozilla.org/en-US/docs/Web/CSS/attr(). The page used a table for values of the <type-or-unit> value, and then used white-space: nowrap; to stop the type names from wrapping.

I've chosen to replace the table with a nested dl:

  • this is a more conventional way to do this in our docs
  • it will work better in Markdown than a table
  • it gives the main text for each item more horizontal space rather than squeezing it into a cell

I dropped the "Associated type" bit because it seemed obvious from the description.

@wbamberg wbamberg requested a review from a team as a code owner June 1, 2021 04:38
@wbamberg wbamberg requested review from ericwbailey and removed request for a team June 1, 2021 04:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/attr()
Title: attr()
on GitHub

No new external URLs

(this comment was updated 2021-06-01 04:45:55.726996)

Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rachelandrew rachelandrew merged commit 2920887 into mdn:main Jun 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@wbamberg wbamberg deleted the remove-inline-styles-attr branch October 15, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants