Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF90 - remove ftp #5485

Merged
merged 6 commits into from
Jun 1, 2021
Merged

FF90 - remove ftp #5485

merged 6 commits into from
Jun 1, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 31, 2021

Fixes #5388

FTP was removed from Firefox in FF90. This PR:

  • Updates release notes
  • Removes the preference from experimental features
  • A few other cosmetic improvements to FTP related pages as I came to them.

It does not remove the proxy setting for FTP (as that has not been reomved)

I previously removed most relevant stuff for FF88 so not much to do.

@hamishwillee hamishwillee requested review from a team as code owners May 31, 2021 02:25
@hamishwillee hamishwillee requested a review from a team May 31, 2021 02:25
@hamishwillee hamishwillee requested a review from a team as a code owner May 31, 2021 02:25
@hamishwillee hamishwillee requested review from Rumyra and chrisdavidmills and removed request for a team May 31, 2021 02:25
@hamishwillee hamishwillee mentioned this pull request May 31, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021

Preview URLs

Flaws

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Basics_of_HTTP/Identifying_resources_on_the_Web
Title: Identifying resources on the Web
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/Document/autoplayPolicy does not exist
    • /en-US/docs/Web/API/GeometryUtils/convertPointFromNode does not exist
    • /en-US/docs/Web/API/GeometryUtils/convertRectFromNode does not exist
    • /en-US/docs/Web/API/GeometryUtils/convertQuadFromNode does not exist
    • /en-US/docs/Web/API/GeometryUtils/getBoxQuads does not exist

External URLs

URL: /en-US/docs/Learn/Common_questions
Title: Common questions
on GitHub

No new external URLs


URL: /en-US/docs/Learn/Common_questions/What_is_a_URL
Title: What is a URL?
on GitHub

No new external URLs


URL: /en-US/docs/Learn/Common_questions/Upload_files_to_a_web_server
Title: How do you upload your files to a web server?
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Basics_of_HTTP/Identifying_resources_on_the_Web
Title: Identifying resources on the Web
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Releases/90
Title: Firefox 90 for developers
on GitHub

No new external URLs


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
on GitHub


URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings
Title: proxy.settings
on GitHub

No new external URLs


URL: /en-US/docs/Glossary/FTP
Title: FTP
on GitHub

No new external URLs

(this comment was updated 2021-06-01 01:10:58.865224)

@hamishwillee hamishwillee dismissed Rob--W’s stale review June 1, 2021 01:09

Rob tells me that the requested change is not needed (proxy was not removed)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me; thanks @hamishwillee !

@chrisdavidmills chrisdavidmills merged commit eca14db into mdn:main Jun 1, 2021
@hamishwillee hamishwillee deleted the ff90_remove_ftp branch June 4, 2021 05:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP] Remove ftp
3 participants