-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put browser-compat info in front-runner for api/[opq]* #5420
Put browser-compat info in front-runner for api/[opq]* #5420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good to me but a merge conflict needs resolving. |
# Conflicts: # files/en-us/web/api/paymentaddress/regioncode/index.html
The conflict was the removal of PaymentAddress.regionCode by foolip in #5434. I merged the head and I think this was an error. |
There is a new conflict now and it looks like it is due to a bad merge? This PR is huge now. |
Yes, I think I mixed something. I wonder if I should not just rebase to main/HEAD: the extra file will be gone and I'll merge the CSP header that have been changed overnight. This should keep this PR readable. What do you think, @Elchi3 ? |
Yeah, either you resolve it here or you start with a fresh PR based on the latest head. I don't mind, whatever seems most effective for you. :) |
I'm closing this one in profit of #5536. |
We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).
This PR covers api/[opq]* for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).
406 files in api/*
openwebdocs/project#36