Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML input elements: use bcd front-matter and spec macro #5166

Merged
merged 1 commit into from
May 20, 2021
Merged

HTML input elements: use bcd front-matter and spec macro #5166

merged 1 commit into from
May 20, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented May 20, 2021

BCD has spec_urls for all of our input pages :)

@Elchi3 Elchi3 requested a review from a team as a code owner May 20, 2021 19:28
@Elchi3 Elchi3 requested review from rachelandrew and removed request for a team May 20, 2021 19:28
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub
Flaw count: 10

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist
    • /en-US/docs/Web/API/DOMContentLoaded does not exist
    • /en-US/docs/Web/API/HTMLInputElement/checkValidity does not exist
    • /en-US/docs/Web/API/HTMLInputElement/setCustomValidity does not exist
    • and 4 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/valueAsNumber does not exist
  • sectioning:
    • Excess <h3> tag that is NOT at root-level (id='Standards', text='Standards')

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/checkbox
Title: <input type="checkbox">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Element/input/button
Title: <input type="button">
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/list
    • Can't resolve /en-US/docs/Web/HTML/Attributes/placeholder

URL: /en-US/docs/Web/HTML/Element/input/color
Title: <input type="color">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/datetime-local
Title: <input type="datetime-local">
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Element/input/url
Title: <input type="url">
on GitHub
Flaw count: 2

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:23
      21| }
      22| %>

23| <%- await wiki.page(url, $1, $2, $3, $4) %>
24|

unable to find an HTML element with an "id" of "autocorrect" within /en-us/docs/web/html/element/input/text`

  • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/page.ejs:23
    21| }
    22| %>

23| <%- await wiki.page(url, $1, $2, $3, $4) %>
24|

unable to find an HTML element with an "id" of "mozactionhint" within /en-us/docs/web/html/element/input/text`

URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Glossary/OS does not exist
    • /en-US/docs/Web/API/HTMLInputElement/value does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionStart does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionEnd does not exist
    • /en-US/docs/Web/API/HTMLInputElement/selectionDirection does not exist

External URLs

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/image
Title: <input type="image">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/range
Title: <input type="range">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/week
Title: <input type="week">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/checkbox
Title: <input type="checkbox">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/date
Title: <input type="date">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/button
Title: <input type="button">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/tel
Title: <input type="tel">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/email
Title: <input type="email">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/file
Title: <input type="file">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/color
Title: <input type="color">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/datetime-local
Title: <input type="datetime-local">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/hidden
Title: <input type="hidden">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/radio
Title: <input type="radio">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/url
Title: <input type="url">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/text
Title: <input type="text">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/number
Title: <input type="number">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/month
Title: <input type="month">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/submit
Title: <input type="submit">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/search
Title: <input type="search">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/reset
Title: <input type="reset">
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/input/password
Title: <input type="password">
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these changes

@wbamberg wbamberg merged commit 41a17d8 into mdn:main May 20, 2021
@Elchi3 Elchi3 deleted the html-input-spec-compat branch May 21, 2021 06:33
@teoli2003 teoli2003 mentioned this pull request May 30, 2021
Closed
51 tasks
@teoli2003
Copy link
Contributor

(For tracking purpose) This is part of #1146.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @teoli2003 @wbamberg