Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML global attributes: use browser-compat front-matter + spec macro #5149

Merged
merged 1 commit into from
May 20, 2021
Merged

HTML global attributes: use browser-compat front-matter + spec macro #5149

merged 1 commit into from
May 20, 2021

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented May 20, 2021

Also remove BCD contribution notes if present

@Elchi3 Elchi3 requested a review from a team as a code owner May 20, 2021 13:34
@Elchi3 Elchi3 requested review from rachelandrew and removed request for a team May 20, 2021 13:34
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 18 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Global_attributes
Title: Global attributes
on GitHub
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/Events/Event_handlers
    • Can't resolve /en-US/docs/Web/HTML/Global_attributes/exportparts
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/HTML/Global_attributes/itemtype
Title: itemtype
on GitHub
Flaw count: 8

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 3 more flaws omitted

URL: /en-US/docs/Web/HTML/Global_attributes/translate
Title: translate
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLElement/translate does not exist

URL: /en-US/docs/Web/HTML/Global_attributes/enterkeyhint
Title: enterkeyhint
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLElement/enterkeyhint

URL: /en-US/docs/Web/HTML/Global_attributes/data-*
Title: data-*
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/HTMLElement/dataset redirects to /en-US/docs/Web/API/HTMLOrForeignElement/dataset
    • /en-US/docs/Web/API/HTMLElement/dataset redirects to /en-US/docs/Web/API/HTMLOrForeignElement/dataset
    • /en-US/docs/Web/API/HTMLElement/dataset redirects to /en-US/docs/Web/API/HTMLOrForeignElement/dataset

URL: /en-US/docs/Web/HTML/Global_attributes/accesskey
Title: accesskey
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Element/accessKey redirects to /en-US/docs/Web/API/HTMLElement/accessKey

URL: /en-US/docs/Web/HTML/Global_attributes/tabindex
Title: tabindex
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/HTMLElement/tabIndex redirects to /en-US/docs/Web/API/HTMLOrForeignElement/tabIndex
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/HTMLElement/focus
    • Anchor not lowercase
    • Anchor not lowercase
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/HTML/Global_attributes/class
Title: class
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Learn/CSS/

URL: /en-US/docs/Web/HTML/Global_attributes/id
Title: id
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Anchor not lowercase

URL: /en-US/docs/Web/HTML/Global_attributes/itemscope
Title: itemscope
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

External URLs

URL: /en-US/docs/Web/HTML/Global_attributes
Title: Global attributes
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/itemtype
Title: itemtype
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/translate
Title: translate
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/enterkeyhint
Title: enterkeyhint
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/itemprop
Title: itemprop
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/dir
Title: dir
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/data-*
Title: data-*
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/accesskey
Title: accesskey
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/style
Title: style
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/tabindex
Title: tabindex
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/spellcheck
Title: spellcheck
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/class
Title: class
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/hidden
Title: hidden
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/slot
Title: slot
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/itemid
Title: itemid
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/part
Title: part
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/contextmenu
Title: contextmenu
on GitHub

URL: /en-US/docs/Web/HTML/Global_attributes/autocapitalize
Title: autocapitalize
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/id
Title: id
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/lang
Title: lang
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/itemref
Title: itemref
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/title
Title: title
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/inputmode
Title: inputmode
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/is
Title: is
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/nonce
Title: nonce
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/draggable
Title: draggable
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/itemscope
Title: itemscope
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Global_attributes/contenteditable
Title: contenteditable
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes May 20, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me, Florian!

@wbamberg wbamberg merged commit a90c5d2 into mdn:main May 20, 2021
@Elchi3 Elchi3 deleted the html-ga-spec-compat branch May 21, 2021 06:33
@teoli2003 teoli2003 mentioned this pull request May 30, 2021
Closed
51 tasks
@teoli2003
Copy link
Contributor

(For tracking purpose) This is part of #1146.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@rachelandrew rachelandrew Awaiting requested review from rachelandrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @teoli2003 @wbamberg