Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove adjacent dt elements #5076

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

wbamberg
Copy link
Collaborator

This PR removes adjacent <dt> elements, as discussed in #4367 (comment), replacing them with a single <dt> containing multiple terms, except in one case where it replaces them with a <ul>.

@wbamberg wbamberg requested review from a team as code owners May 18, 2021 02:52
@wbamberg wbamberg requested review from ericwbailey, mirunacurtean and sideshowbarker and removed request for a team May 18, 2021 02:52
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness
Title: Equality comparisons and sameness
on GitHub
Flaw count: 3

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/Accessibility/Implementing_MSAA_server
Title: Implementing a Microsoft Active Accessibility (MSAA) Server
on GitHub
Flaw count: 1

  • heading_links:
    • h3 heading contains an <a> tag

URL: /en-US/docs/Web/CSS/list-style-type
Title: list-style-type
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/CSS/color_value
    • Anchor not lowercase

URL: /en-US/docs/Web/API/File_and_Directory_Entries_API
Title: File and Directory Entries API
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/FileSystemFileEntrySync does not exist
    • /en-US/docs/Web/API/FileSystemDirectoryEntrySync does not exist
    • /en-US/docs/Web/API/FileSystemDirectoryReaderSync does not exist
    • /en-US/docs/Web/API/FileSystemDirectoryEntrySync/createReader does not exist
  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/API/HTMLScriptElement
Title: HTMLScriptElement
on GitHub
Flaw count: 22

  • macros:
    • /en-US/docs/Web/API/HTMLScriptElement/type does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/src does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/event does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/charset does not exist
    • /en-US/docs/Web/API/HTMLScriptElement/async does not exist
    • and 6 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/Events/DOMContentLoaded
    • Can't resolve /en-US/docs/DOM/document.write
    • Can't resolve /en-US/docs/Web/HTML/CORS_settings_attributes
    • Can't resolve /en-US/docs/DOM/Text
    • Can't resolve /en-US/docs/DOM/Node.textContent
    • and 6 more flaws omitted

External URLs

URL: /en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness
Title: Equality comparisons and sameness
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/compare
Title: Intl.Collator.prototype.compare()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/resolvedOptions
Title: Intl.Collator.prototype.resolvedOptions()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions
Title: Intl.DateTimeFormat.prototype.resolvedOptions()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/resolvedOptions
Title: Intl.NumberFormat.prototype.resolvedOptions()
on GitHub

No new external URLs


URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/PluralRules/resolvedOptions
Title: Intl.PluralRules.prototype.resolvedOptions()
on GitHub

No new external URLs


URL: /en-US/docs/Web/Accessibility/Implementing_MSAA_server
Title: Implementing a Microsoft Active Accessibility (MSAA) Server
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTML/Inline_elements
Title: Inline elements
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file
Title: Proxy Auto-Configuration (PAC) file
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/list-style-type
Title: list-style-type
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/align-items
Title: align-items
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/color_value
Title: <color>
on GitHub

No new external URLs


URL: /en-US/docs/Web/CSS/custom-ident
Title: <custom-ident>
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/File_and_Directory_Entries_API
Title: File and Directory Entries API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/HTMLScriptElement
Title: HTMLScriptElement
on GitHub

No new external URLs

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. As previously discussed, looks at least as good as the original.

@hamishwillee hamishwillee merged commit 7467e3e into mdn:main May 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
@wbamberg wbamberg deleted the remove-adjacent-dt branch October 15, 2022 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants