Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PaymentAddress, PayerErrors, and related members #4850

Merged
merged 1 commit into from
May 12, 2021
Merged

Deprecate PaymentAddress, PayerErrors, and related members #4850

merged 1 commit into from
May 12, 2021

Conversation

sideshowbarker
Copy link
Member

w3c/payment-request@486c07a (w3c/payment-request#955) removed the PaymentAddress and PayerErrors objects from the Payment Request specification — as well as removing related members from the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects.

So this change adds Deprecated and Non-standard banners to the PaymentAddress and PayerErrors articles, as well as to the articles for all their member, and to the articles for the related members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects.

The change also removes all the Specifications tables for the deprecated features (they’re no longer in the spec).

Related BCD change: mdn/browser-compat-data#10413

@sideshowbarker sideshowbarker requested a review from a team as a code owner May 10, 2021 02:28
@sideshowbarker sideshowbarker requested review from Rumyra and removed request for a team May 10, 2021 02:28
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/PaymentResponse
Title: PaymentResponse
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/PaymentResponse/payerEmail
Title: PaymentResponse.payerEmail
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/PaymentOptions does not exist

URL: /en-US/docs/Web/API/PaymentResponse/payerPhone
Title: PayerResponse.payerPhone
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/PaymentOptions does not exist

URL: /en-US/docs/Web/API/PaymentResponse/payerdetailchange_event
Title: PaymentResponse: payerdetailchange event
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/API/PaymentResponse/shippingOption
Title: PaymentResponse.shippingOption
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentOptions does not exist
    • /en-US/docs/Web/API/PaymentRequest/onshippingaoptionchange does not exist

URL: /en-US/docs/Web/API/PaymentRequest
Title: PaymentRequest
on GitHub
Flaw count: 1

  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/PaymentRequest/shippingoptionchange_event
Title: PaymentRequest: shippingoptionchange event
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/PaymentReques/onshippingoptionchange does not exist

URL: /en-US/docs/Web/API/PaymentRequest/shippingOption
Title: PaymentRequest.shippingOption
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/PaymentRequest/onshippingaoptionchange does not exist

URL: /en-US/docs/Web/API/PaymentDetailsUpdate
Title: PaymentDetailsUpdate
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/API/PaymentDetailsBase/displayItems does not exist
    • /en-US/docs/Web/API/PaymentDetailsUpdate/updateWith does not exist
    • /en-US/docs/Web/API/PaymentDetailsBase/modifiers does not exist
    • /en-US/docs/Web/API/PaymentDetailsModifier does not exist
    • /en-US/docs/Web/API/PaymentDetailsBase/shippingOptions does not exist
    • and 2 more flaws omitted
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/PaymentDetailsUpdate/error
Title: PaymentDetailsUpdate.error
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PaymentRequest/requestShipping does not exist
    • /en-US/docs/Web/API/PaymentDetailsUpdate/shippingOptions does not exist

URL: /en-US/docs/Web/API/PaymentAddress
Title: PaymentAddress
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Web/API/PaymentAddress/postalCode
Title: PaymentAddress.postalCode
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/PaymentAddress/regionCode
Title: PaymentAddress.regionCode
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

External URLs

URL: /en-US/docs/Web/API/PaymentResponse
Title: PaymentResponse
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/payerEmail
Title: PaymentResponse.payerEmail
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/onpayerdetailchange
Title: PaymentResponse.onpayerdetailchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/shippingAddress
Title: PaymentResponse.shippingAddress
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/payerName
Title: PaymentRequest.payerName
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/payerPhone
Title: PayerResponse.payerPhone
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/payerdetailchange_event
Title: PaymentResponse: payerdetailchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentResponse/shippingOption
Title: PaymentResponse.shippingOption
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest
Title: PaymentRequest
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingoptionchange_event
Title: PaymentRequest: shippingoptionchange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/onshippingaddresschange
Title: PaymentRequest.onshippingaddresschange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingAddress
Title: PaymentRequest.shippingAddress
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/onshippingoptionchange
Title: PaymentRequest.onshippingoptionchange
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingType
Title: PaymentRequest.shippingType
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingaddresschange_event
Title: PaymentRequest: shippingaddresschange event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentRequest/shippingOption
Title: PaymentRequest.shippingOption
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentDetailsUpdate
Title: PaymentDetailsUpdate
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentDetailsUpdate/error
Title: PaymentDetailsUpdate.error
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentDetailsUpdate/shippingAddressErrors
Title: PaymentDetailsUpdate.shippingAddressErrors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress
Title: PaymentAddress
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/organization
Title: PaymentAddress.organization
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/city
Title: PaymentAddress.city
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/dependentLocality
Title: PaymentAddress.dependentLocality
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/phone
Title: PaymentAddress.phone
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/addressLine
Title: PaymentAddress.addressLine
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/languageCode
Title: PaymentAddress.languageCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/recipient
Title: PaymentAddress.recipient
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/country
Title: PaymentAddress.country
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/postalCode
Title: PaymentAddress.postalCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/regionCode
Title: PaymentAddress.regionCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/region
Title: PaymentAddress.region
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/toJSON
Title: PaymentAddress.toJSON()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PaymentAddress/sortingCode
Title: PaymentAddress.sortingCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PayerErrors
Title: PayerErrors
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PayerErrors/phone
Title: PayerErrors.phone
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PayerErrors/name
Title: PayerErrors.name
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/PayerErrors/email
Title: PayerErrors.email
on GitHub

No new external URLs

@sideshowbarker
Deprecate PaymentAddress, PayerErrors, and related members
d248fe2 
w3c/payment-request@486c07a
(w3c/payment-request#955) removed the
PaymentAddress and PayerErrors objects from the Payment Request
specification — as well as removing related members from the
PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects.

So this change adds Deprecated and Non-standard banners to the
PaymentAddress and PayerErrors articles, as well as to the articles for
all their member, and to the articles for the related members of the
PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects.

The change also removes all the Specifications tables for the deprecated
features (they’re no longer in the spec).

Related BCD change: mdn/browser-compat-data#10413
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/PaymentAddress-PayerErrors-deprecate branch from fd0b52c to d248fe2 Compare May 10, 2021 02:33
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request May 10, 2021
@sideshowbarker
Deprecate PaymentAddress, PayerErrors, and related members
195066b 
w3c/payment-request@486c07a
(w3c/payment-request#955) removed the
PaymentAddress and PayerErrors objects from the Payment Request
specification — as well as removing related members from the
PaymentRequest, PaymentResponse, and PaymentDetailsUpdate objects.

So this change marks PaymentAddress and PayerErrors as deprecated and
standard_track:false, as well as all their members, and the related
members of the PaymentRequest, PaymentResponse, and PaymentDetailsUpdate
objects.

The change also removes all the spec URLs for the deprecated features
(they’re no longer in the spec).

Related MDN change: mdn/content#4850
This was referenced May 10, 2021
Merged
Merged
wbamberg
wbamberg approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @sideshowbarker !

@wbamberg wbamberg merged commit fe4914d into main May 12, 2021
@wbamberg wbamberg deleted the sideshowbarker/PaymentAddress-PayerErrors-deprecate branch May 12, 2021 03:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideshowbarker @wbamberg