Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Markdown table syntax #4718

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented May 5, 2021

This PR is to document the decisions about writing tables in Markdown from #4325.

I also moved up the "Extensions" headings to H2 so they are reachable from the ToC. Why doesn't the ToC list H3 headings?

I also ended up removing the bit that talks about interesting things GFM supports (tables and code fences/info strings) because that sits better in the sections that make use of these features.

@wbamberg wbamberg requested a review from a team as a code owner May 5, 2021 03:46
@wbamberg wbamberg requested review from Elchi3 and removed request for a team May 5, 2021 03:46
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented May 5, 2021

GitHub is showing me an unverified commit (in case that would block merge once the review passes).

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @wbamberg 👍

I think the unverified commit is no problem here but it might be good if Will fixes it at some point :) It is required for yari afaik.

@Elchi3 Elchi3 merged commit 0417987 into mdn:main May 6, 2021
@wbamberg
Copy link
Collaborator Author

wbamberg commented May 6, 2021

Yeah I know. Somewhere along the way GitHub forgot who I am.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants