-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove spec tables in JS docs, and replace with macro call #4691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaict only the lexical grammar table doesn't work.
For trailing commas, Mike submitted a BCD PR.
The rest looks really great 🎉
files/en-us/web/javascript/reference/lexical_grammar/index.html
Outdated
Show resolved
Hide resolved
This seems to leave us with 10 pages under /JavaScript that use
I wonder what we should do about them. It would be nice to retire SpecData. |
I wonder if these pages could have the spec links in See also (or if we really want, in "Specifications") as list items. In any case, I don't see a need that they should go through macro processing. It is just links... |
Let's do this! :) |
(For tracking purpose) This is part of #1146. |
@Elchi3 , here's that PR.
It only looks at pages that already have the
browser-compat
front matter item.I guess it won't be mergeable until after mdn/yari#3518 gets deployed :).