Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spec tables in JS docs, and replace with macro call #4691

Merged
merged 2 commits into from
May 5, 2021

Conversation

wbamberg
Copy link
Collaborator

@wbamberg wbamberg commented May 4, 2021

@Elchi3 , here's that PR.

It only looks at pages that already have the browser-compat front matter item.

I guess it won't be mergeable until after mdn/yari#3518 gets deployed :).

@wbamberg wbamberg requested a review from Elchi3 May 4, 2021 05:47
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaict only the lexical grammar table doesn't work.
For trailing commas, Mike submitted a BCD PR.
The rest looks really great 🎉

@wbamberg
Copy link
Collaborator Author

wbamberg commented May 4, 2021

This seems to leave us with 10 pages under /JavaScript that use {{SpecName}}:

files/en-us/web/javascript//guide/regular_expressions/unicode_property_escapes/index.html:   <td>{{SpecName('ESDraft', '#sec-runtime-semantics-unicodematchproperty-p', 'RegExp: Unicode property escapes')}}</td>
files/en-us/web/javascript//guide/regular_expressions/groups_and_ranges/index.html:   <td>{{SpecName('ESDraft', '#sec-classranges', 'RegExp: Ranges')}}</td>
files/en-us/web/javascript//guide/regular_expressions/quantifiers/index.html:   <td>{{SpecName('ESDraft', '#sec-quantifier', 'RegExp: Quantifiers')}}</td>
files/en-us/web/javascript//guide/regular_expressions/character_classes/index.html:   <td>{{SpecName('ESDraft', '#sec-characterclass', 'RegExp: Character classes')}}</td>
files/en-us/web/javascript//guide/regular_expressions/assertions/index.html:   <td>{{SpecName('ESDraft', '#sec-assertion', 'RegExp: Assertions')}}</td>
files/en-us/web/javascript//data_structures/index.html:   <td>{{SpecName('ESDraft', '#sec-ecmascript-data-types-and-values', 'ECMAScript Data Types and Values')}}</td>
files/en-us/web/javascript//eventloop/index.html:   <td>{{SpecName('HTML WHATWG', 'webappapis.html#event-loops', 'Event loops')}}</td>
files/en-us/web/javascript//reference/iteration_protocols/index.html:   <td>{{SpecName('ESDraft', '#sec-iteration', 'Iteration')}}</td>
files/en-us/web/javascript//reference/lexical_grammar/index.html:			<td>{{SpecName('ESDraft', '#sec-ecmascript-language-lexical-grammar', 'Lexical Grammar')}}</td>
files/en-us/web/javascript//reference/strict_mode/index.html:   <td>{{SpecName('ESDraft', '#sec-strict-mode-code', 'Strict Mode Code')}}</td>

I wonder what we should do about them. It would be nice to retire SpecData.

@Elchi3
Copy link
Member

Elchi3 commented May 4, 2021

I wonder if these pages could have the spec links in See also (or if we really want, in "Specifications") as list items.

In any case, I don't see a need that they should go through macro processing. It is just links...

@Elchi3 Elchi3 marked this pull request as ready for review May 5, 2021 10:30
@Elchi3 Elchi3 requested a review from a team as a code owner May 5, 2021 10:30
@Elchi3
Copy link
Member

Elchi3 commented May 5, 2021

Let's do this! :)

@teoli2003
Copy link
Contributor

(For tracking purpose) This is part of #1146.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
@wbamberg wbamberg deleted the remove-spec-tables-js branch October 15, 2022 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants