-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-deprecate ShadowRoot.p.delegatesFocus #4508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL. Related BCD change: mdn/browser-compat-data#10102
sideshowbarker
force-pushed
the
sideshowbarker/ShadowRoot-delegatesFocus
branch
from
April 27, 2021 02:24
5ce4f98
to
7723336
Compare
Preview URLsFlawsNone! 🎉 External URLsURL:
(this comment was updated 2021-04-27 02:26:28.422566) |
sideshowbarker
added a commit
to w3c/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change resets the BCD status flags for it. Related MDN change: mdn/content#4508
foolip
pushed a commit
to mdn/browser-compat-data
that referenced
this pull request
Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit. So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change resets the BCD status flags for it. Related MDN change: mdn/content#4508
Elchi3
approved these changes
Apr 27, 2021
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Aug 13, 2022
Completes fix done in mdn#4508.
teoli2003
pushed a commit
that referenced
this pull request
Aug 13, 2022
Completes fix done in #4508.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit.
So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL.
Related BCD change: mdn/browser-compat-data#10102