Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate ShadowRoot.p.delegatesFocus #4508

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented Apr 27, 2021

whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus to the DOM spec (see whatwg/dom@f346858). And per whatwg/dom#931 (comment) (https://trac.webkit.org/r276585) it’s been implemented in WebKit.

So given that it’s now part of the DOM standard, and implemented in multiple browsers, this change drops the Deprecated_Header macro from the source — as well as fixing the spec URL.

Related BCD change: mdn/browser-compat-data#10102

@sideshowbarker sideshowbarker requested a review from a team as a code owner April 27, 2021 02:23
@sideshowbarker sideshowbarker requested review from wbamberg and removed request for a team April 27, 2021 02:23
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus
to the DOM spec (see whatwg/dom@f346858). And
per whatwg/dom#931 (comment)
(https://trac.webkit.org/r276585) it’s been implemented in WebKit.

So given that it’s now part of the DOM standard, and implemented in multiple
browsers, this change drops the Deprecated_Header macro from the source — as
well as fixing the spec URL.

Related BCD change: mdn/browser-compat-data#10102
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/ShadowRoot/delegatesFocus
Title: ShadowRoot.delegatesFocus
on GitHub

(this comment was updated 2021-04-27 02:26:28.422566)

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus
to the DOM spec (see whatwg/dom@f346858). And
per whatwg/dom#931 (comment)
(https://trac.webkit.org/r276585) it’s been implemented in WebKit.

So given that it’s now part of the DOM standard, and implemented in multiple
browsers, this change resets the BCD status flags for it.

Related MDN change: mdn/content#4508
foolip pushed a commit to mdn/browser-compat-data that referenced this pull request Apr 27, 2021
whatwg/dom#974 added ShadowRoot.prototype.delegatesFocus
to the DOM spec (see whatwg/dom@f346858). And
per whatwg/dom#931 (comment)
(https://trac.webkit.org/r276585) it’s been implemented in WebKit.

So given that it’s now part of the DOM standard, and implemented in multiple
browsers, this change resets the BCD status flags for it.

Related MDN change: mdn/content#4508
@Elchi3 Elchi3 merged commit d92c1a9 into main Apr 27, 2021
@Elchi3 Elchi3 deleted the sideshowbarker/ShadowRoot-delegatesFocus branch April 27, 2021 10:09
OnkarRuikar added a commit to OnkarRuikar/content that referenced this pull request Aug 13, 2022
teoli2003 pushed a commit that referenced this pull request Aug 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants