-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix http:// links to https:// where certain (2) #4456
fix http:// links to https:// where certain (2) #4456
Conversation
@@ -830,7 +830,7 @@ <h2 id="See_also">See also</h2> | |||
|
|||
<ul> | |||
<li><a href="https://expressjs.com/en/guide/database-integration.html">Database integration</a> (Express docs)</li> | |||
<li><a href="http://mongoosejs.com/">Mongoose website</a> (Mongoose docs)</li> | |||
<li><a href="https://mongoosejs.com/">Mongoose website</a> (Mongoose docs)</li> | |||
<li><a href="http://mongoosejs.com/docs/guide.html">Mongoose Guide</a> (Mongoose docs)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbe Why not this one? And the ones that follow? Did you just search on the top level URLs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird! That must mean there's something wrong with my script. Dang.
@@ -591,8 +591,8 @@ <h3 id="Language_grammar_spelling">Language, grammar, spelling</h3> | |||
<li><a href="http://www.amazon.com/Writing-Well-30th-Anniversary-Nonfiction/dp/0060891548">On Writing Well</a>, by William Zinsser (Amazon link)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbe Looks good to me, though I obviously didn't check every link to validate that they actually do support https. Approved on this basis
Some thoughts:
- I saw at some links either side of the fixed ones that were not updated to https - I highlighted a couple so you can check why not caught. Some of these are in the same domain so I would presume have just been missed.
- Would be cool if the class "external" was removed as part of these fixes, since you're tidying the URLs anyway.
@hamishwillee Thank you for catching! I now know what was wrong with my script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterbe Looks great - just visual inspection - can't actually check all the URLs support HTTPS.
Another big batch following #4416