Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix inconsistency between description and code example for min-height… #36731

Closed
wants to merge 2 commits into from

Conversation

FelixTakeOne
Copy link
Contributor

@FelixTakeOne FelixTakeOne commented Nov 11, 2024

… value

According to the example, the minimum height of the box is half of its width (200px), so I changed the text's 150px to 100px to match the code.

Description

Update the text to reflect the correct min-height value of 100px, based on the example where the box's minimum height is half of its width (200px).

Motivation

This change ensures consistency between the text description and the code example for the min-height property, helping readers better understand the layout behavior.

Additional details

Section:min- and max- sizes
https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Sizing_items_in_CSS

Related issues and pull requests

Fixes #36725

… value

According to the example, the minimum height of the box is half of its width (200px), so I changed the text's 150px to 100px to match the code.
@FelixTakeOne FelixTakeOne requested a review from a team as a code owner November 11, 2024 09:33
@FelixTakeOne FelixTakeOne requested review from estelle and removed request for a team November 11, 2024 09:33
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/xs [PR only] 0-5 LoC changed labels Nov 11, 2024
@FelixTakeOne FelixTakeOne changed the title Fix inconsistency between description and code example for min-height… docs: fix inconsistency between description and code example for min-height… Nov 11, 2024
@bsmth
Copy link
Member

bsmth commented Nov 11, 2024

Thank you, this was fixed in #36729

@bsmth bsmth closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:CSS Learning area CSS docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent min-height (prose vs code)
2 participants