-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(css): Create easing function pages #36697
base: main
Are you sure you want to change the base?
Conversation
Preview URLs (7 pages)External URLs (7)URL:
URL:
URL:
URL:
URL:
(comment last updated: 2024-11-22 14:46:16) |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thanks :) I have one fix and a few suggestions:
- Quotes inside of alts might not be useful for the target users or even potentially problematic since we encode them.
- The alt descriptions we provide for graphs might not be comprehensible due to their complexity and length. I wonder if we should reconsider the approach and explain them in prose next to images.
Here’s the longest example:
Graphs of Input progress to Output progress, of which steps(2, jump-start) shows horizontal lines extending 0.5 unit from (0, 0.5) and (0.5, 1), respectively, with empty circles at the origin and (0.5, 0.5); steps(4, jump-end) shows horizontal lines extending 0.25 unit from (0, 0), (0.25, 0.25), (0.5, 0.5), and (0.75, 0.75), respectively, with unfilled circles at (0.25, 0), (0.5, 0.25), and (0.75, 0.5), and a solid circle at (1, 1); steps(5, jump-none) shows horizontal lines extending 0.2 unit from (0, 0), (0.2, 0.25), (0.4, 0.5), (0.6, 0.75), and (0.8, 1), respectively, with unfilled circles at (0.2, 0), (0.4, 0.25), (0.6, 0.5), and (0.8, 0.75); steps(3, jump-both) shows horizontal lines extending 1/3 unit from (0, 0.25), (1/3, 0.5), and (2/3, 0.75),respectively , with a solid circle at (1, 1) and unfilled circles at the origin, (1/3, 0.25), (2/3, 0.5), and (1, 0.75).
Describing this picture:
We might also split the picture in multiple parts and describe each individually.
Co-authored-by: Vadim Makeev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, I'm leaving a +1 -> @pepelsbey I have two suggestions if you want to take a look 👀
Co-authored-by: Brian Smith <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Currently, the documentation for
linear()
,cubic-bezier()
, andsteps()
easing functions exists only within the<easing-function>
data type page.This PR:
Creates individual reference pages for
linear()
,cubic-bezier()
, andsteps()
functions from the content on the<easing-function>
page.Updates the
<easing-function>
page:Similarly, aligns the "Parameters" section on each function page with its "Formal syntax".
The "Specifications" section is being updated in Add spec_url for new CSS easing functions browser-compat-data#25041.
Note
This is the first iteration of the function pages. Future improvements can include:
Related issues and pull requests
Fixes #29923