Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 36368: HttpOnly cookies can't be accessed by JS, not just n… #36453

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix issue 36368: HttpOnly cookies can't be accessed by JS, not just n… #36453

merged 1 commit into from
Oct 23, 2024

Conversation

wbamberg
Copy link
Collaborator

Fixes #36368, as suggested in #36368 (comment).

@wbamberg wbamberg requested a review from a team as a code owner October 23, 2024 04:16
@wbamberg wbamberg requested review from bsmth and removed request for a team October 23, 2024 04:16
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

bsmth
bsmth approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@bsmth bsmth merged commit aece74a into mdn:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question on cookie's httpOnly attribute
2 participants
@wbamberg @bsmth