Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: scrollHeight example #36440

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Fix: scrollHeight example #36440

merged 6 commits into from
Oct 24, 2024

Conversation

ragul1697
Copy link
Contributor

Description

Fixes #36365 - Added 1px allowance for scrollHeight calculation

@ragul1697 ragul1697 requested a review from a team as a code owner October 22, 2024 13:50
@ragul1697 ragul1697 requested review from wbamberg and removed request for a team October 22, 2024 13:50
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Oct 22, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Preview URLs

(comment last updated: 2024-10-23 06:41:36)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle requested a review from wbamberg October 24, 2024 21:50
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @ragul1697 !

@wbamberg wbamberg merged commit 59d50a9 into mdn:main Oct 24, 2024
8 checks passed
@ragul1697 ragul1697 deleted the patch-1 branch October 25, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subpixel tolerance for scrollHeight demo
2 participants