Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates api/element/Element:QuerySelectorAll() example, fixes #35003 #35006

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

tasinttttttt
Copy link
Contributor

Description

Updates the example in order to make it work.

Motivation

...

Additional details

none

Related issues and pull requests

Fixes #35003

@tasinttttttt tasinttttttt requested a review from a team as a code owner July 23, 2024 22:29
@tasinttttttt tasinttttttt requested review from wbamberg and removed request for a team July 23, 2024 22:29
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 23, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the commented-out examples and add a link to attribute selectors in the prose above?

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Preview URLs

(comment last updated: 2024-07-25 19:09:28)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@Josh-Cena Josh-Cena merged commit cea377d into mdn:main Jul 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element.querySelectorAll() examples: HTML & JS don't correspond
2 participants