Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add width requirements and clip computation for the overflow property #33433

Merged
merged 2 commits into from
May 13, 2024
Merged

Add width requirements and clip computation for the overflow property #33433

merged 2 commits into from
May 13, 2024

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented May 6, 2024 •
edited
Loading

No description provided.

@geryogam
Add the ‘clip’ value of property ‘overflow’ computed to the ‘hidden’ …
a8f6465 
…value if a different value is set for the other axis
@geryogam geryogam requested a review from a team as a code owner May 6, 2024 10:17
@geryogam geryogam requested review from estelle and removed request for a team May 6, 2024 10:17
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited
Loading

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/overflow
Title: overflow
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics

(comment last updated: 2024-05-13 09:38:54)

@geryogam geryogam changed the title Add the ‘clip’ value of property ‘overflow’ computed to the ‘hidden’ value if a different value is set for the other axis Add ‘clip’ computed to ‘hidden’ for property ‘overflow’ if a different value is set for the other axis May 6, 2024
@geryogam geryogam changed the title Add ‘clip’ computed to ‘hidden’ for property ‘overflow’ if a different value is set for the other axis Add value ‘clip’ computed to value ‘hidden’ for property ‘overflow’ if a different value is set for the other axis May 6, 2024
@geryogam geryogam changed the title Add value ‘clip’ computed to value ‘hidden’ for property ‘overflow’ if a different value is set for the other axis Add width requirements and clip computation for the overflow property. May 13, 2024
@geryogam geryogam changed the title Add width requirements and clip computation for the overflow property. Add width requirements and clip computation for the overflow property May 13, 2024
estelle
estelle approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 9bbdc50 into mdn:main May 13, 2024
8 checks passed
@geryogam
Copy link
Contributor Author

Thanks for the review!

@geryogam geryogam deleted the patch-1 branch October 26, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geryogam @estelle