Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up CODEOWNERS file #33170

Merged
merged 4 commits into from
Apr 22, 2024
Merged

chore: tidy up CODEOWNERS file #33170

merged 4 commits into from
Apr 22, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Apr 19, 2024

Description

The CODEOWNERS is a little hard to read due to formatting. I'm proposing to get rid of the banner-style comments and replace redundant information.

Motivation

Readability for humans.

How to review this PR

You can ignore whitespace-only changes here:

https://github.com/mdn/content/pull/33170/files?diff=split&w=1

@bsmth bsmth requested a review from a team as a code owner April 19, 2024 10:07
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Apr 19, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @bsmth, I have just one suggestion but it's not a blocker.
Thanks for the cleanup!

.github/CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
@bsmth
Copy link
Member Author

bsmth commented Apr 22, 2024

Super, thank you!

@bsmth bsmth merged commit 92fdc73 into mdn:main Apr 22, 2024
6 of 7 checks passed
@bsmth bsmth deleted the codeowners-tidy branch April 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants