Added "period" for clarity of what a "full stop" is. #33155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a little confusing to NA English readers.
github-actions
bot
added
Content:Learn:CSS
wbamberg
reviewed
Apr 19, 2024
| @@ -151,7 +151,7 @@ So far, we have styled elements based on their HTML element names. This works as | |||
| </ul> | |||
| ``` | |||
|
|
|||
| 2. In your CSS, you can target the class of `special` by creating a selector that starts with a full stop character. Add the following to your CSS file: | |||
| 2. In your CSS, you can target the class of `special` by creating a selector that starts with a period/full stop character. Add the following to your CSS file: | |||
There was a problem hiding this comment.
Suggested change
| 2. In your CSS, you can target the class of `special` by creating a selector that starts with a period/full stop character. Add the following to your CSS file: | |
| 2. In your CSS, you can target the class of `special` by creating a selector that starts with a period. Add the following to your CSS file: |
We don't need "full stop" at all. This was probably written by a British person :).
|
Thanks a lot! Let's remove "full stop" as Will suggests :) |
|
Preview URLs (comment last updated: 2024-04-19 21:12:05) |
|
Didn't realize I could just click "commit suggestion" 😂. In any case, change is made! |
wbamberg
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny change, added the word "period" for clarity of what a "full stop" character is to avoid confusion for NA English readers.
Motivation
I have only rarely seen a period referred to as a full stop, despite it being the technically correct name for the character. I believe this adds a touch of clarity for readers who may be unfamiliar with the term.