Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention CPU architecture inside OS User Agent detection page #33135

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

busybox11
Copy link
Contributor

Not entirely sure about this one, as Mac still doesn't report ARM in its user agent for Apple silicon macs. Windows does though, and this mention could've saved me some headaches.

Description

Motivation

Additional details

Related issues and pull requests

Not entirely sure about this one, as Mac still doesn't report ARM in its user agent for Apple silicon macs.
Windows does though, and this mention could've saved me some headaches.
@busybox11 busybox11 requested a review from a team as a code owner April 17, 2024 14:00
@busybox11 busybox11 requested review from teoli2003 and removed request for a team April 17, 2024 14:00
@github-actions github-actions bot added Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed labels Apr 17, 2024
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@teoli2003 teoli2003 merged commit 30760ba into mdn:main Apr 22, 2024
7 checks passed
@teoli2003
Copy link
Contributor

Thanks a lot!

This PR looks good to me.

Congratulations upon your first merged commit here! Welcome aboard! ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants