Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macro): remove inline status macros from CSS value sections, part 2 #32820

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(macro): remove inline status macros from CSS value sections, part 2 #32820

merged 1 commit into from
Mar 25, 2024

Conversation

OnkarRuikar
Copy link
Contributor

ping @wbamberg

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner March 25, 2024 04:59
@OnkarRuikar OnkarRuikar requested review from bsmth and removed request for a team March 25, 2024 04:59
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (30 pages)
Flaws (17)

Note! 24 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/display-inside
Title: <display-inside>
Flaw count: 2

  • bad_bcd_queries:
    • No BCD data for query: css.properties.display.table_values
    • No BCD data for query: css.properties.display.ruby_values

URL: /en-US/docs/Web/CSS/CSS_basic_user_interface
Title: CSS basic user interface
Flaw count: 6

  • macros:
    • /en-US/docs/Web/CSS/caret does not exist
    • /en-US/docs/Web/CSS/caret-shape does not exist
    • /en-US/docs/Web/CSS/nav-down does not exist
    • /en-US/docs/Web/CSS/nav-left does not exist
    • /en-US/docs/Web/CSS/nav-right does not exist
    • and 1 more flaws omitted

URL: /en-US/docs/Web/CSS/CSS_backgrounds_and_borders
Title: CSS backgrounds and borders
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/background-position-inline does not exist
    • /en-US/docs/Web/CSS/background-position-block does not exist

URL: /en-US/docs/Web/CSS/CSS_masking
Title: CSS masking
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/clip-rule does not exist

URL: /en-US/docs/Web/CSS/CSS_overflow
Title: CSS overflow
Flaw count: 4

  • macros:
    • /en-US/docs/Web/CSS/block-ellipsis does not exist
    • /en-US/docs/Web/CSS/continue does not exist
    • /en-US/docs/Web/CSS/line-clamp does not exist
    • /en-US/docs/Web/CSS/max-lines does not exist

URL: /en-US/docs/Web/CSS/display-internal
Title: <display-internal>
Flaw count: 2

  • bad_bcd_queries:
    • No BCD data for query: css.properties.display.table_values
    • No BCD data for query: css.properties.display.ruby_values
External URLs (1)

URL: /en-US/docs/Web/CSS/:empty
Title: :empty

hamishwillee
hamishwillee reviewed Mar 25, 2024
View reviewed changes
files/en-us/web/css/_colon_empty/index.md
@@ -84,5 +84,5 @@ The text that provides the interactive control's accessible name can be hidden u

## See also

- {{CSSxRef(":-moz-only-whitespace")}} {{Non-standard_Inline}} – The {{glossary("Vendor_Prefix", "prefixed")}} implementation of the changes in [Selectors Level 4](https://drafts.csswg.org/selectors-4/#the-empty-pseudo)
- {{CSSxRef(":blank")}} {{Experimental_Inline}}
- {{CSSxRef(":-moz-only-whitespace")}} – The {{glossary("Vendor_Prefix", "prefixed")}} implementation of the changes in [Selectors Level 4](https://drafts.csswg.org/selectors-4/#the-empty-pseudo)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FMI, does the scripting add inline markup to See also as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were status badges in 'See also' lists (and many weird places) way before the bot was put in place. So the bot targeted all the lists.
But now we've modified the bot to only consider definition lists <dt><dl>. And after these PRs, CSS pages won't see any inline status badges till we conclude how to represent status badges discussion.

hamishwillee
hamishwillee approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@hamishwillee hamishwillee merged commit 8d4fb1e into mdn:main Mar 25, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_remove_inline_macros branch March 26, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@bsmth bsmth Awaiting requested review from bsmth bsmth is a code owner automatically assigned from mdn/yari-content-css

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @hamishwillee