Synchronize with BCD v5.5.14 #32594

OnkarRuikar · 2024-03-07T00:26:32Z

BCD release v5.5.14

/cc @queengooborg @sideshowbarker

github-actions · 2024-03-07T00:28:04Z

Preview URLs (43 pages)

Flaws (18)

Note! 40 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/ruby-align
Title: ruby-align
Flaw count: 1

macros:
- /en-US/docs/Web/CSS/ruby-merge does not exist

URL: /en-US/docs/Web/API/Element
Title: Element
Flaw count: 1

macros:
- /en-US/docs/Web/API/Element/getBoxQuads does not exist

URL: /en-US/docs/Web/API/RTCOutboundRtpStreamStats
Title: RTCOutboundRtpStreamStats
Flaw count: 16

macros:
- /en-US/docs/Web/API/RTCSentRtpStreamStats does not exist
- /en-US/docs/Web/API/RTCOutboundRtpStreamStats/qualityLimitationDurations does not exist
- /en-US/docs/Web/API/RTCRemoteInboundRtpStreamStats does not exist
- /en-US/docs/Web/API/RTCRemoteInboundRtpStreamStats does not exist
- /en-US/docs/Web/API/RTCOutboundRtpStreamStats/retransmittedBytesSent does not exist
- and 11 more flaws omitted

(comment last updated: 2024-03-12 10:29:25)

files/en-us/web/css/hanging-punctuation/index.md

wbamberg · 2024-03-07T03:51:45Z

files/en-us/web/css/hanging-punctuation/index.md

@@ -53,7 +53,7 @@ The `hanging-punctuation` property may be specified with one, two, or three spac

 ### Values

- `none`
+- `none` {{experimental_inline}}


However also it looks like the script here is marking every value of the property experimental, rather than the main property itself. That doesn't seem right.

The bot simply mimics BCD. It's a bug in BCD:

The property should be marked experimental in BCD then the bot will reflect it in the page baner.

submitted a fix in BCD: Fix a bug in hanging-punctuation property status browser-compat-data#22568

Asking the question again which got wrongfully made in review comment below.

@Elchi3 why the hanging-punctuation property was made non-experimental and not its values? At least one value should've been non-experimental right?

wbamberg · 2024-03-07T04:02:32Z

files/en-us/web/css/margin-trim/index.md

@@ -32,31 +32,31 @@ margin-trim: unset;

 ### Values

- `none`
+- `none` {{experimental_inline}}


Here again, if the property itself is experimental, why mark all the values experimental?

Technically, because BCD tracks it like that: all the values have a separate status tracked.

The bot simply mimics the BCD i.e. track property(page header) and values(inline badges) separately.

Pros of separate tracking:

Keeps the implementation simple. Keeps BCD the single source of truth.

Third party scraping tools won't have to be intelligent too. Many popular IDEs use MDN snippets as it is in tool tips.

Readers landed from search engines directly on the property won't have to scroll up to see if it's experimental.

Reviews will become complex as in localised diff a value, that remained experimental after the property becomes non experimental, will look like going non-experimental to experimental.

Note that this is different from the decision that was made about secure context: https://github.com/orgs/mdn/discussions/482#discussioncomment-7796301. Why are we inconsistent here?

Why are we inconsistent here?

Does the inline secure context discussion and decision apply to all the inline macros? Putting this in weekly meeting agenda.

wbamberg · 2024-03-08T17:42:18Z

files/en-us/web/css/content-visibility/index.md

 browser-compat: css.properties.content-visibility
 ---

-{{CSSRef}}{{SeeCompatTable}}
+{{CSSRef}}


Here and in many other cases, the main property is not marked experimental, but all its values are. What does this mean?

wbamberg · 2024-03-08T17:43:09Z

files/en-us/web/css/initial-letter/index.md

@@ -35,7 +35,7 @@ The keyword value `normal`, or a `<number>` optionally followed by an `<integer>

 ### Values

- `normal`
+- `normal` {{experimental_inline}}


Here, the main property is marked experimental, but not all its values are.

This is a BCD issue. @Elchi3 why the property was made non-experimental and not its values? At least one value should've been non-experimental right?

This is a BCD issue.

Not sure what this has to do with initial-letter.

@Elchi3 why the property was made non-experimental and not its values? At least one value should've been non-experimental right?

The initial-letter property is supported in Chrome and Safari, so it is not experimental. (although, given it is only supported with a prefix in Safari, one could argue). The normal property is likely also supported in Safari and not just Chrome, so this is the bug in BCD. Maybe @queengooborg did not take into account prefixes when adding CSS property values?

Prefixes are not tracked by the mdn-bcd-collector, so any prefix-based data was recorded manually. I've just submitted mdn/browser-compat-data#22596 to correct the Safari data for the normal value.

In regards to the experimental status, actually, the initial-letter property is accurately marked as experimental. Per the experimental status guidelines, prefixes are basically ignored when picking an experimental status. Experimental should be set to false if Chrome and Safari both supported the property without a prefix; in this case, only one browser does.

Not sure what this has to do with initial-letter.

Ohh, the statement was for the hanging-punctuation. The comment accidentally got made in the review box below (here).

However, mdn/browser-compat-data#22596 made it confusing for the initial-letter property. It is experimental but its value(s) are not. 😕

The comment accidentally got made in the review box below (here).

?? My comment here was for initial-letter, and it is that the property is marked experimental at the top level, but not all its values are. I don't understand this. If the property is experimental "as a whole", how can it have values that are not experimental?

hanging-punctuation has a different issue, that I've also commented on, which is that it is not marked experimental at the top level, but all its values are. If all its values are experimental, how does it make sense for the property itself to be not experimental?

wbamberg · 2024-03-08T17:46:53Z

files/en-us/web/css/text-align/index.md

  - : The inline contents are aligned to the right edge of the line box.
- `center` {{deprecated_inline}} {{non-standard_inline}}
+- `center`


justify-all is marked as experimental in this one but missing in the BCD table.

The property doesn't exist in the BCD code.

files/en-us/web/css/text-size-adjust/index.md

wbamberg · 2024-03-08T17:59:40Z

files/en-us/web/css/text-decoration-skip/index.md

@@ -38,7 +38,7 @@ text-decoration-skip: unset;

 ### Values

- `none`
+- `none` {{experimental_inline}}


Property is marked experimental, not all values are.

BCD doesn't cover all the values here. The page author(s) should've have added these to BCD. Or we should have some mechanism to report these in BCD.

wbamberg · 2024-03-08T18:01:09Z

files/en-us/web/css/text-justify/index.md

  - : The text is justified by adding space between words (effectively varying {{cssxref("word-spacing")}}), which is most appropriate for languages that separate words using spaces, like English or Korean.
- `inter-character`
+- `inter-character` {{experimental_inline}}
  - : The text is justified by adding space between characters (effectively varying {{cssxref("letter-spacing")}}), which is most appropriate for languages like Japanese.
 - `distribute` {{deprecated_inline}}


Property is not marked experimental, all values are except this one, which is not listed in BCD.

files/en-us/web/css/timeline-scope/index.md

wbamberg · 2024-03-08T18:02:38Z

files/en-us/web/css/view-timeline-inset/index.md

@@ -32,7 +32,7 @@ view-timeline-inset: 20% 200px;

 Allowed values for `view-timeline-inset` are:

- `auto`
+- `auto` {{experimental_inline}}
  - : If set, the corresponding {{cssxref("scroll-padding")}} (or equivalent longhand value) for that edge of the scrollport is used. If this is not set (or set to `auto`), the value will usually be 0, although some user agents may use heuristics to determine a different default value if appropriate.
 - {{cssxref("length-percentage")}}


Property is marked experimental but this value isn't.

The value doesn't exist in BCD.

wbamberg · 2024-03-08T18:03:02Z

files/en-us/web/css/view-transition-name/index.md

@@ -26,7 +26,7 @@ view-transition-name: none;

 - {{cssxref("custom-ident")}}


Property is marked experimental but this value isn't.

The value doesn't exist in BCD.

OnkarRuikar · 2024-03-09T05:37:31Z

Pinging BCD maintainers those who have worked on CSS props recently @queengooborg @hamishwillee @Elchi3
Common issues are:

If a property is made non-experimental from experimental then at least one value should be also made non-experimental.
There are some values in content that are not tracked in BCD. How can we get them tracked in BCD? Report an issue in BCD whenever the script finds such values?

github-actions · 2024-03-12T00:00:25Z

This pull request has merge conflicts that must be resolved before it can be merged.

OnkarRuikar · 2024-03-26T04:39:53Z

Closing in favour of #32835

OnkarRuikar requested review from a team as code owners March 7, 2024 00:26

OnkarRuikar requested review from wbamberg, teoli2003 and dipikabh and removed request for a team March 7, 2024 00:26

github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:HTTP HTTP docs Content:Manifest size/m [PR only] 51-500 LoC changed labels Mar 7, 2024

wbamberg reviewed Mar 7, 2024

View reviewed changes

OnkarRuikar mentioned this pull request Mar 7, 2024

Fix a bug in hanging-punctuation property status mdn/browser-compat-data#22568

Merged

OnkarRuikar force-pushed the sync_bcd branch 2 times, most recently from 7d7bc94 to 9dac6d6 Compare March 8, 2024 09:59

wbamberg reviewed Mar 8, 2024

View reviewed changes

OnkarRuikar and others added 2 commits March 9, 2024 11:10

Synchronize with BCD v5.5.14

d4c1f47

fix the bug

875ef8b

OnkarRuikar force-pushed the sync_bcd branch from 9dac6d6 to 875ef8b Compare March 9, 2024 05:40

handle CSS types

776b82a

github-actions bot added the merge conflicts 🚧 [PR only] label Mar 12, 2024

queengooborg closed this in mdn/browser-compat-data#22568 Mar 12, 2024

queengooborg reopened this Mar 12, 2024

Merge branch 'main' into sync_bcd

bfd0eff

github-actions bot removed the merge conflicts 🚧 [PR only] label Mar 12, 2024

OnkarRuikar marked this pull request as draft March 12, 2024 10:28

OnkarRuikar mentioned this pull request Mar 18, 2024

Is "text-align: center" really deprecated and non-standard?!? #32700

Closed

OnkarRuikar closed this Mar 26, 2024

OnkarRuikar deleted the sync_bcd branch March 27, 2024 03:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Synchronize with BCD v5.5.14 #32594

Synchronize with BCD v5.5.14 #32594

OnkarRuikar commented Mar 7, 2024

github-actions bot commented Mar 7, 2024 •

edited

Loading

wbamberg Mar 7, 2024

OnkarRuikar Mar 7, 2024

OnkarRuikar Mar 7, 2024

OnkarRuikar Mar 12, 2024

wbamberg Mar 7, 2024

OnkarRuikar Mar 7, 2024 •

edited

Loading

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024

wbamberg Mar 8, 2024

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024 •

edited

Loading

Elchi3 Mar 11, 2024 •

edited

Loading

queengooborg Mar 12, 2024

OnkarRuikar Mar 12, 2024

wbamberg Mar 12, 2024

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024 •

edited

Loading

wbamberg Mar 8, 2024

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024

wbamberg Mar 8, 2024

OnkarRuikar Mar 9, 2024

OnkarRuikar commented Mar 9, 2024

github-actions bot commented Mar 12, 2024

OnkarRuikar commented Mar 26, 2024

		@@ -26,7 +26,7 @@ view-transition-name: none;

		- {{cssxref("custom-ident")}}

Synchronize with BCD v5.5.14 #32594

Synchronize with BCD v5.5.14 #32594

Conversation

OnkarRuikar commented Mar 7, 2024

github-actions bot commented Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OnkarRuikar Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OnkarRuikar Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

Elchi3 Mar 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OnkarRuikar Mar 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OnkarRuikar commented Mar 9, 2024

github-actions bot commented Mar 12, 2024

OnkarRuikar commented Mar 26, 2024

github-actions bot commented Mar 7, 2024 •

edited

Loading

OnkarRuikar Mar 7, 2024 •

edited

Loading

OnkarRuikar Mar 9, 2024 •

edited

Loading

Elchi3 Mar 11, 2024 •

edited

Loading

OnkarRuikar Mar 9, 2024 •

edited

Loading