Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix GitHub workflow part in URL check script #32519

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Mar 2, 2024


The deleted slug check does exist for offline husky hook. But looks like the author ignored both the warnings and submitted the PR with --no-verify flag:

Offline warnings

warning


The PR fixes workflow run part by adding deleted slug check part.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner March 2, 2024 07:13
@OnkarRuikar OnkarRuikar requested review from bsmth and removed request for a team March 2, 2024 07:13
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Mar 2, 2024
@OnkarRuikar OnkarRuikar changed the title fix(ci): Fix URL check script GitHub workflow part fix(ci): Fix GitHub workflow part in URL check script Mar 2, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsmth
Copy link
Member

bsmth commented Mar 7, 2024

Let's land it and keep an eye on runs.

@bsmth bsmth merged commit 08d5648 into mdn:main Mar 7, 2024
7 of 8 checks passed
@OnkarRuikar OnkarRuikar deleted the ci_fix_url_check branch March 8, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants