Point to the correct parent of SVGDescElement (SVGElement, not SVGGeometryElement) #32433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metryElement. Source: https://svgwg.org/svg2-draft/struct.html#InterfaceSVGDescElement Also, align phrasing among the 7 actual children of SVGGeometryElement.
targumon
requested review from
sideshowbarker
and removed request for
a team
github-actions
bot
added
Content:WebAPI
|
Preview URLs
Flaws (8)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
(comment last updated: 2024-02-25 22:26:06) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hamishwillee
approved these changes
Feb 25, 2024
There was a problem hiding this comment.
Good catch thanks @targumon . I've modified the wording on these to match the page template for API reference (yes, consistency is excellent to have here, and OK in same PR).
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The correct parent interface for
SVGDescElementisSVGElementSource: https://svgwg.org/svg2-draft/struct.html#InterfaceSVGDescElement
(the Inheritance Diagram is correct, I just fixed the text/link).
Motivation
Accuracy 🤓
Additional details
Since I was looking at the 7 actual children of
SVGGeometryElement, I also aligned some of their phrasing(I adhere to LIBTYFI ⚜️ so I hope it's okay I did it in the same PR).